Incorporate list feedback from Mark Harris, Tim and Jean-Marc
and try to improve clarity.

From http://www.ietf.org/mail-archive/web/codec/current/msg03030.html

In glib 2.17 the __malloc_ptr define was removed in favour
of using void* directly. Our declaration of mhook using this
type for the second argument therefore rightly generates a warning
on modern systems, since the type is assumed to be an int, which
is too narrow to hold a pointer on 64 bit architectures.

Since it was only ever a define we could use an #ifndef to define
__malloc_ptr ourselves. However we only use it once, so using void*
in the signature directly is cleaner. This should cause no problems
on older systems where it will match either the void* or the char*
(for non __STDC__ code) the define resolved to.

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

This was causing pseudostack builds to fail because opus_demo uses a 2-second
buffer.

Also minor C89 fix for the previous commit

This saves 640 bytes on the peak stack usage.

We only keep when concealing less than 10ms with SILK.

Since we're doing two rotations, we can invert the sign on both.
Also adding a few comments for optimizing the FFT.

Also simplifying the code

Undoes commits f7547a4e and 72513f3c