- May 15, 2013
-
-
Timothy B. Terriberry authored
This shouldn't really be necessary when static linking, but would be if someone wanted chang the Makefile to build shared libraries.
-
- May 13, 2013
-
-
Ron authored
-
Ron authored
Partly just to give us an extra commit to test the versioning, but they really aren't needed in any of those cases, and now we're consistent about not using them everywhere.
-
Ron authored
This one meets or exceeds the following requirements: - Version is checked/updated for every build action when in the git repo. Does not require the user to re- ./configure to get the correct version. - Version is not updated automatically when using exported tarball source. Avoids accidentally getting a wrong version from some other git repo in a parent directory of the source, and allows setting the correct version for distro package exports. - Automatic updating can be manually suppressed. For developers doing lots of change/rebuild cycles they don't plan to release, when they don't want a full rebuild triggered for every commit, and again for every change made immediately after a commit. The version will still always be updated if they do a `make dist`. - Does not require any manual updating of versions in the mainline git repo for each release aside from normal tagging. The version is recorded in one file only, that is automatically generated and will never need to be committed. - Does not require gnu-make features for the autoconf builds. It does not currently: - Keep a checksum of every source file in tarball releases to mangle the version if people modify the tarball source. Responsible people can manually update the version easily though in such cases.
-
Ron authored
-
Ron authored
-
Ron authored
If --disable-http is used it will just only have file URL support.
-
Ron authored
-
Ron authored
-
Timothy B. Terriberry authored
This makes it easier to split http.c and friends into their own library. This allows distributions to ship a libopusfile with generic Opus parsing support, and a libopusurl with http/https support. Keeping the latter in a separate library means that GPL applications don't have to link against the GPL-incompatible openssl, and distributions don't have to disable http support to allow GPL applications to use libopusfile.
-
- May 08, 2013
-
-
Timothy B. Terriberry authored
If we actually have 255 packets on a page, this assertion always triggers, because ogg_stream_packetout doesn't fail until we ask for the _next_ packet.
-
- May 07, 2013
-
-
Timothy B. Terriberry authored
If a stream starts with a non-zero granpos, we would subtract 80 ms from the target time, and then report failure when the best page we could find (the first page in the link) had a granpos larger than that. This worked for normal streams because the subtraction would fail (granpos can't wrap past -1) and we checked for that.
-
- May 01, 2013
-
-
Timothy B. Terriberry authored
This shouldn't be necessary, but apparently on OS X 10.4 fseeko() takes fpos_t instead of off_t, and thus doesn't guarantee that off_t is defined.
-
- Apr 30, 2013
-
-
Timothy B. Terriberry authored
-
Signed-off-by:
Timothy B. Terriberry <tterribe@xiph.org>
-
Libraries that are used internally by opusfile but are not part of its API should be listed in pkg-config "private" clauses. Otherwise executables that are linked dynamically against opusfile will have unneeded direct dependencies (overlinking). Signed-off-by:
Timothy B. Terriberry <tterribe@xiph.org>
-
The library does not actually do any playback, as it does no sound output. Signed-off-by:
Timothy B. Terriberry <tterribe@xiph.org>
-
Signed-off-by:
Timothy B. Terriberry <tterribe@xiph.org>
-
AC_SEARCH_LIBS will give a result of "none required" if the relevant function is available without any special libraries. This is the case for lrintf on MinGW. Make sure this special value isn't put verbatim into the pkg-config files, as it would cause the linker to search for files named "none" and "required", and fail. Signed-off-by:
Timothy B. Terriberry <tterribe@xiph.org>
-
- Apr 28, 2013
-
-
Timothy B. Terriberry authored
I thought I had tested this before, but it was sufficiently broken that clearly I had not.
-
- Apr 06, 2013
-
-
Timothy B. Terriberry authored
stdarg.h should've been inside the include guard.
-
Timothy B. Terriberry authored
- Made OP_SOFT_CLIP defined only when using floating point (libopus handles clipping when using the fixed-point API). - Struct rearrangement for theoretically better packing on some platforms. - Reset the state tracking channel count when re-initializing a decoder (and not the dither mute, because that gets reset for free).
-
- Mar 25, 2013
-
-
Timothy B. Terriberry authored
When we decode using libopus's fixed-point APIs, libopus internally applies soft clipping prevention. When we decode using libopus's floating-point APIs, this behavior is disabled. If we're ultimately planning to output the data to the user in fixed-point, we need to apply the clipping prevention ourselves.
-
Timothy B. Terriberry authored
The caller can switch between the fixed/float APIs and the stereo/multichannel APIs on every call. Detect this and reset the dither state to avoid potentially injecting noise from a very out-of-date state when switching from fixed to float back to fixed, or from the wrong channels when switching between stereo and multichannel. Normal applications won't do this stuff, but we should be well-behaved if they do.
-
Timothy B. Terriberry authored
-
Timothy B. Terriberry authored
For multichannel files, this potentially caused writes beyond the end of the output buffer provided by the user.
-
- Mar 01, 2013
-
-
Ralph Giles authored
-
Ralph Giles authored
-
Ralph Giles authored
Reduces cruft on 'make clean'. I've rearranged some of the non-functional self-test targets, but not really fixed them.
-
Timothy B. Terriberry authored
The old ones gave a different warning on Apple's clang 4.2.
-
Ralph Giles authored
This is required by the xmingw build.
-
- Feb 28, 2013
-
-
Timothy B. Terriberry authored
Just normalizing coding style.
-
-
OpenSSL on Windows does not pull certificates from any well-known location (in fact most binaries continue to use the default Unix path, which usually doesn't even exist). We could ship our own set of certificates (e.g., cloned from the Mozilla root list), but I don't want to be responsible for releasing libopusfile updates when things like DigiNotar fiasco [1] happen. That approach also means that we would need to load, parse, and keep a copy of every certificate in the system for every SSL session. OpenSSL has had patches sitting in their bugtracker which load certificates from the Crypto API's system certificate store. However, those patches have been sitting around for several years, so movement on that front in the near future seems unlikely. We don't care about using OpenSSL's builtin CAPI engine, though, so we can do the same thing with less than 200 lines of code. This puts the maintenance burden on Windows Update, which will be far more timely and effective than getting people to upgrade libopusfile, and gets us on-demand loading of just the certificates we need. [1] <https://bugzilla.mozilla.org/show_bug.cgi?id=682927>
-
-
Apparently Vista includes more things in its Winsock implementation and errno.h than earlier versions of Windows.
-
This keeps differences which can be cleanly abstracted away clean (closesocket, ioctlsocket, getsockopt, setsockopt), and makes differences which cannot be cleanly abstracted explicit (SOCKET, INVALID_SOCKET, WSAGetLastError/WSASetLastError). It also gets rid of wsockwrapper.[ch], since it contained just a single function. This can successfully pass the seeking_example tests on big.chained.blob over https when built with i686-w64-mingw32 and run under wine. It does not solve the certificate distribution problems with using OpenSSL on a real Windows system.
-
It turns out i686-pc-mingw32 does define these functions, and they are always available (unlike _fseeki64/_ftelli64). This means we can build and link without requiring i686-w64-mingw32. The resulting binary still doesn't run in wine for me, but that may be a personal problem.
-
This allows an i686-pc-mingw32 build to use getaddrinfo/ freeaddrinfo correctly. It's not needed for an i686-w64-mingw32 build, but it doesn't hurt to leave it in here. i686-pc-mingw32 still won't work correctly, because it does not support fseeko/ftello, nor (unless using MSVCRT 8.0 or later) _fseeki64/_ftelli64. We could define __MSVCRT_VERSION__ to 0x800 to get the latter, but this would require different MSVCRT versions than libogg and libopus are built with by default, which makes a bit of a mess.
-