The 'needs_rec' parameter for one of the two rdo_mode_decision() calls by
topdown parition search has been passed with wrong value.
It should be false, since re-encoding step follows once rdo_mode_decision()
decided the mode.
In fact, we don't need 'needs_rec' parameter in rdo_mode_decision(), so remove it.

This patch will cause loss of coding efficiency (0.1250% at speed 1)
with a small speedup.

However, if there is more than one intra prediction blocks in a
partition, i.e. tx_size < partition size, rdo_mode_decision() will need
generate reconstrtucted pixels for intra prediction modes. Sine tx
partition is not provided by rav1e yet, this condition can be
implemented in the future.

Thomas Daede authored 6 years ago and Thomas Daede committed 6 years ago

Fixes #954

Enable tx domain distortion at speed >= 4 instead of >= 1

This way, the default speed (3) always uses pixel domain distortion
which is easier to understand while we figure out what our quantizers
should look like, how to set lambda, what distortion metrics to use,
etc.

Note that this only affects --tune Psnr since --tune Psychovisual always
uses (weighted) pixel domain distortion.

At speed 3 with --tune Psnr the metrics change are:

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.1422 | -0.4571 | -0.2197 |  -0.1806 | -0.1451 | -0.1617 |    -0.5266

And the encoding speed seems to be only very slightly reduced.

* Mention rectangular blocks
* Mention directional modes

This reverts commit 634d1a99.

Jeremy Fitzhardinge authored 6 years ago and Thomas Daede committed 6 years ago

Without it, a vendored version of the crate won't build.

Ewout ter Hoeven authored 6 years ago and Thomas Daede committed 6 years ago

Switch AppVeyor badge link to https://ci.appveyor.com/project/tdaede/rav1e/history

Nathan E. Egge authored 6 years ago and Nathan Egge committed 6 years ago

Part of #938.

Nathan E. Egge authored 6 years ago and Nathan Egge committed 6 years ago

Part of #938.

VideoDetails is mainly used while decoding y4m, but it is carried
around in the configuration, initializing various internal structures.

Having all encoding-related fields in a single structure simplifies
setting up and configuring the encoder, as well as offering
an easier-to-use and possibly a more extensible API.

Fix #910.

Silences a warning while running the decode_test feature test.

Also correct help message, now that it works for 4x4.

Note in the help text which is the default.
Fix #905.