Remove getters
Currently libshout provides a number of getters for several settings. It seems unclear to me what they are useful for. Therefore I suggest to deprecate them and remove them with the next ABI change.
List of relevant getters:
shout_get_host()
shout_get_port()
shout_get_agent()
-
shout_get_tls()
There is/was/might be confusion on whether this returns the configuration or the current value. shout_get_ca_directory()
shout_get_ca_file()
-
shout_get_allowed_ciphers()
The value is not supposed to be set by the API user. Therefore a getter may be still be good (e.g. for status display). shout_get_user()
-
shout_get_password()
Via #2338 shout_get_client_certificate()
shout_get_mount()
shout_get_audio_info()
shout_get_meta()
shout_get_public()
shout_get_content_language()
shout_get_content_format()
-
shout_get_protocol()
There is/was/might be confusion on whether this returns the configuration or the current value. -
shout_get_nonblocking()
The returned value is aSHOUT_BLOCKING_xxx
constant. There had been confusion on this before.