Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Icecast-Server
Icecast-Server
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.Org
  • Icecast-ServerIcecast-Server
  • Issues
  • #791

Closed
Open
Opened Dec 19, 2005 by gtgbr@gtgbr

[PATCH] More type related cleanups

More type related cleanups:

  • Add casts where implicit casting would happen otherwise (covers all, except those int->char casts that are harmless.)

  • Resolve accuracy issues, mostly by changing long to int (except in one case in source.c where it's the other way round)

  • More int -> size_t changes when buffer sizes are involved. While doing so, slightly rewrite get_line() in auth_htpasswd.c to not shadow the len parameter.

  • While in httpp.h, remove prototype for nonexistent function httpp_parse_icy()

  • Adjust sanity checks to not test whether an unsigned variable is < 0

  • In net/sock.c, use sizeof(ip) instead of MAX_ADDR_LEN

  • Do not forget to #include <sys/types.h> and "compat.h" whenever _t types are used

Assignee
Assign to
Icecast 2.5.0
Milestone
Icecast 2.5.0
Assign milestone
Time tracking
None
Due date
None
Reference: xiph/icecast-server#791