Skip to content
Snippets Groups Projects

Fix: Add missing files in admin/ dir after make install (closes #2395)

Closed Gilou requested to merge gilou/icecast-server:fix_missing_files_admin into master
1 unresolved thread

Merge request reports

Pipeline #2168 failed

Pipeline failed for 1f509a36 on gilou:fix_missing_files_admin

Approval is optional

Closed by Philipp SchafftPhilipp Schafft 4 years ago (Oct 9, 2020 8:29am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Thanks, this looks good, will have another look during the week.

      Nitpick: Commit message could be simplified to something like: Fix: Add missing admin files to dist and the Closes #2395 should be in the commit message body not the first line, IMO.

    • Let me know what's the policy hehe, I didn't find info about the workflow, so it's in the commit message, and the MR used it… As for the commit message, I'm used to only use commit messages on a line for simple commits, but again, happy to comply to any policy applied here…

      Edited by Gilou
    • Please register or sign in to reply
  • Gilou added 1 commit

    added 1 commit

    • 1f509a36 - Fix: Add missing admin files to dist

    Compare with previous version

  • Hi. Isn't the admin/showlog.xsl missing in the merge request?

Please register or sign in to reply
Loading