Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • L libao
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 36
    • Issues 36
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.OrgXiph.Org
  • libao
  • Issues
  • #1904
Closed
Open
Issue created Sep 24, 2012 by Ed Schwartz@edmcman

Silent option handling can lead to pain

Hi,

I just spent an hour or so debugging a painful, silly user error.

The problem was that I commented out some lines in /etc/libao.conf by prepending #.

Some drivers, like alsa, allow options with unknown keys to be set. Other drivers, like pulse, do not.

I had a commented out line with the alsa driver (which worked), and could not figure out why the pulse driver would mysteriously fail!

A quick fix to help stupid people like me would be to add a verbose error message in audio_out.c:

  if (!device->funcs->set_option(device, options->key, options->value)) {
    /* Problem setting options */
    aerror("Unable to set option %s\n", options->key);
    return AO_EOPENDEVICE;
  }

It probably also makes sense to make sure that all audio plugins behave consistently when given invalid options.

Assignee
Assign to
Time tracking