reserved identifier violation

I would like to point out that identifiers like “__OGGZ_H__” and “_OggzVector” do not fit to the expected naming convention of the C++ language standard.

Would you like to adjust your selection for unique names?

I assume you are talking about the "Each name that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use." statement in the linked page. I'll see if I can rename them.

closed with commit 33ffe28e

More update candidates were left over.

Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

reopened

Sure. I got the CI setup working today (.gitlab-ci.yml), and would be happy to add a check for this as well. Perhaps you can make a patch?

Note, I am planning to wrap up a new release fairly soon, so if you want any more symbol fixes into the next release, it would be nice with a patch implementing clang-tidy in the next few days.

mentioned in issue libfishsound#12 (closed)

mentioned in commit 25431ddc

mentioned in merge request !18 (merged)

mentioned in commit e5fc3ae7

mentioned in merge request !19 (merged)

I believe !18 (merged) and !19 (merged) completely fixes this issue. If you want to ensure it do not return, I would most welcome a gitlab CI check for it.

mentioned in commit 6f2f7511

mentioned in commit 79db6269

mentioned in commit a4545348

mentioned in commit 2d9a29e2

mentioned in commit da1e41c0

mentioned in commit 7ed4a28d

mentioned in commit 49032892

mentioned in commit 00652310

closed with merge request !19 (merged)

closed with commit 49032892

Thanks for your source code improvements.