Skip to content

GitLab

Ogg
Ogg
Open
Opened by Helmut K. C. Tessarek@tessus

include file wrong on macOS

The following change in os_types.h from ogg 1.3.3

#elif (defined(__APPLE__) && defined(__MACH__)) /* MacOS X Framework build */

#  include <inttypes.h>

to 1.3.4

#elif (defined(__APPLE__) && defined(__MACH__)) /* MacOS X Framework build */

#  include <sys/types.h>

causes other libs to error out during compile:

eg. for vorbis:

  CC       synthesis.lo
In file included from analysis.c:20:
In file included from /Users/Shared/ffmpeg/sw/include/ogg/ogg.h:24:
/Users/Shared/ffmpeg/sw/include/ogg/os_types.h:75:12: error: unknown type name 'uint16_t'
   typedef uint16_t ogg_uint16_t;
           ^
/Users/Shared/ffmpeg/sw/include/ogg/os_types.h:77:12: error: unknown type name 'uint32_t'
   typedef uint32_t ogg_uint32_t;
           ^
/Users/Shared/ffmpeg/sw/include/ogg/os_types.h:79:12: error: unknown type name 'uint64_t'
   typedef uint64_t ogg_uint64_t;
           ^
  CC       psy.lo
  CC       info.lo
3 errors generated.

I changed the include file to stdint.h and all is fine again. I'm not sure why someone changed it in the first place, but it broke compiling on macOS.