Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

C reserves identifiers of the from _[A-Z]+ and we have a number of
those in the code. This patch renames the various function arguments,
MACROS and preprocessor symbols to avoid the reserved form.

It also removes the CHANNELS() macro altogether. This was a
minor optimization for TI DSP to force a mono-only build,
as were the associated local 'const' versions. Since stereo
support is manditory, it wasn't worth keeping.

Thanks to John Ridges for raising the issue, and Jean-Marc Valin
and Greg Maxwell for reviewing the changes.

These fix corner cases discovered during the latest fuzzing tests.

Undocumented for now

Undocumented for now.

The CELT encoder could end up using a non-max bit-rate and not use
all the bytes it's supposed to use.

Multistream encode was failing to add the length of the extra length for
self-delimited packets causing corrupted output. Multistream decode was
not properly handling lost frames (and potentially reading out of bounds
as a result).

GET_FINAL_RANGE has been implemented as the xor of the final range of all
the streams in the packet.

test_opus_encode now does the mono narrowband tests using dual-mono
multistream.

Newly introduced check_encoder_option failed unconditionally instead of only when you used the wrong options.

And vice versa

This avoids potential alignment issues with allocating a char
array on the stack.

Let's put it back in if/when we have a clearer view of voice/music detection

Also reformat some, but by no means all, of the opus
code for line length and three-character indents.

Renames test_opus to opus_demo and adds the test_opus_api, test_opus_encode, test_opus_decode test programs.

Koen Vos authored 13 years ago and Jean-Marc Valin committed 13 years ago

Also some comment/warning fixes

Only encoder changes were necessary because this uses the same
"redundant frames" mechanism as SILK<->CELT switching.
This also fixes a regression introduced in 78291b27 that was
causing the encoder to go back and forth between bandwidths when
SILK wasn't ready to change.

This is achieved by running the encoding process in a loop and
padding when we don't reach the exact rate. It also implements
VBR-with-cap, which means we no longer need to artificially decrease
the SILK bandwidth when it's close to the cap.

Only one of the two required checks in the encoder were updated. Thanks to
Tim for tracking down the actual cause of the mismatch.

These were caused by not prefilling the hybrid CELT state