Mark Harris authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Jonathan Lennox authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Simplify and generalize implementation of align(). Should be very efficient on sensible platforms, and correct everywhere.

Based on max size of void*, opus_int32 and opus_val32, rounded up to the
nearest power of two

Thanks to Kevin O'Connor for reporting this.

NaN detection should now be able to catch values that would create NaNs
further down.

Padding is now handled by the repacketizer.

This fixes an actual error in the downmix (using the float version even
for the int API), as well as a bunch of conversion warnings.

Newer versions of MSVC are unhappy with the strategy of the build
 environment redefining "inline" (even though they don't support the
 actual keyword). Instead we define OPUS_INLINE to the right thing
 in opus_defines.h.

This is the same approach we use for restrict.

Even when using SILK/hybrid.

This should fix decoding of padded multistream packets and (hopefully)
multistream fec.

Prevents the decoder from being out-of-sync on an invalid packet. Also
returns OPUS_INVALID_PACKET on a corrupted FEC packet.

Should fix delayed decision on surround, but not well tested.

Code is still float, but at least tonality esitmation seems to work.
Speech/music analysis is still disabled.

I checked that it's not *completely* busted, but it probably needs more testing.

opus_decode() and opus_multistream_decode() now apply soft clipping
before converting to 16-bit int. This should produce better a higher
quality result than hard clipping like we were doing before. The _float()
API isn't affected, but the clipping function is exported so users can
manually apply the soft clipping.

Variable duration option renamed to OPUS_SET_EXPERT_FRAME_DURATION,
with new API.
Also moves up the analysis to avoid having to do int->float conversion
on large buffers.

Also fixes a bug with stereo streams where the initial memory was only
using the left channel.

Koen Vos authored 12 years ago and Jean-Marc Valin committed 12 years ago

Conflicts:

	src/opus_multistream.c
	src/opus_private.h

Microsoft Visual Studio 2010 warns about 'C4146: unary minus
operator applied to unsigned type, result still unsigned'
because of the '&-sizeof(void*)' in align().

This commit works around the warning by casting the size_t
to int before negation.

Patch by Hauke, who reported the issue on the opus mailing
list. Reviewed by derf.

This reverts commit 9f407afa.

Gregory Maxwell authored 12 years ago and Jean-Marc Valin committed 12 years ago

OpusCustomMode begins with a pointer and was getting misaligned on 64 bit arches.

OpusCustomMode begins with a pointer and was getting misaligned on 64 bit arches.

Also added 3rd clause to "master" COPYING file

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

C reserves identifiers of the from _[A-Z]+ and we have a number of
those in the code. This patch renames the various function arguments,
MACROS and preprocessor symbols to avoid the reserved form.

It also removes the CHANNELS() macro altogether. This was a
minor optimization for TI DSP to force a mono-only build,
as were the associated local 'const' versions. Since stereo
support is manditory, it wasn't worth keeping.

Thanks to John Ridges for raising the issue, and Jean-Marc Valin
and Greg Maxwell for reviewing the changes.

This avoids potential alignment issues with allocating a char
array on the stack.

Let's put it back in if/when we have a clearer view of voice/music detection

Also merges all the OPUS_*_AUTO into a single OPUS_AUTO parameter

Only tested for the single-stream case!