silk_burg_analysis() could return a slightly negative value on zero
input, which would cause a negative, which the log didn't like.

Without the fix, ubsan would complain about some of the
NULL pointer checks from test_opus_api.

Added proper saturation and rounding

Michael Klingbeil authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Matches the C code and avoids undefined behaviour

Rudi Heitbaum authored 1 year ago and Jean-Marc Valin committed 1 year ago

cc.get_define returns str (not bool)

Fixes:
Fetching value of define "__APPLE__" :
../meson.build:316:12: ERROR: Object <[StringHolder] holds [str]: ''> of type str does not support the `bool()` operator.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

It was breaking badly for PLC.

-fargan-synthesis not -fargan_synthesis

Used to be disabled for LM==0 because of the unreliable energy in
one-bin bands. Now we just used the max with the previous energy to
stabilize things.

Michael Klingbeil authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Timothy B. Terriberry authored 1 year ago and Jean-Marc Valin committed 1 year ago

The existing code in vec_avx.h produced
  warning: dereferencing type-punned pointer will break
   strict-aliasing rules
 with gcc 6.4.0.
We already had a macro to work around this within the rules of the
 C standard, but trying to use that here does not get optimized
 into a single MOVD like we were hoping.
Replacing it with memcpy() instead does get optimized correctly,
 but requires switching from a macro to an inline function in order
 to be able to declare a local variable and return a value.
We already have such an inline function in NSQ_del_dec_avx2.c, so
 hoist that out and use it everywhere, and then convert vec_avx.h
 to use it also.

Also, remove -march=native because of AVX512VNNI and valgrind

Fixes regression in 83368e6.
vcgez_s16() is A64-only, but vcge_s16(..., vdup_n_s16(0)) works
everywhere.

broken in 9cf12e92

Timothy B. Terriberry authored 1 year ago and Jean-Marc Valin committed 1 year ago

Since any value of dQ > 0 will cause the initial quantizer to
 degrade to the format-implied maximum (15) with a sufficient
 number of DRED frames, allow signaling a maximum smaller than 15.
This allows encoders to improve the minimum quality of long DRED
 sequences (at the expense of bitrate) without requiring a constant
 quantizer for all frames (dQ == 0).

Commit 735c4070 added uses of intrinsics that require at least
 gcc 9.0 (cf. <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78782>),
 even though AVX2 support may appear to be available in earlier gcc
 versions.
We were not testing for this.
Update the compiler test in configure.ac to use these intrinsics
 explicitly, so it will error out and disable AVX2 if they are not
 available.

Also, fix documentation about return value of zero.

Trying to add padding in-place breaks when we have extensions,
which causes a memcpy() with overlapping data. Just doing a
copy instead.

Silences NONTHREADSAFE_PSEUDOSTACK warnings

warning: expression does not compute the number of elements in this array
Seems like gcc thinks we're trying to get the number of elements in our
array or something like that. It then suggests adding parentheses to
silence the warning.

Also skip the first loss values being generated since they're
biased towards "not lost" due to the initialization.

Xavier Claessens authored 1 year ago and Jean-Marc Valin committed 1 year ago

They timeout on GitHub actions because those runners are slower.

Giovanni Bajo authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>