Rudi Heitbaum authored 1 year ago and Jean-Marc Valin committed 1 year ago

cc.get_define returns str (not bool)

Fixes:
Fetching value of define "__APPLE__" :
../meson.build:316:12: ERROR: Object <[StringHolder] holds [str]: ''> of type str does not support the `bool()` operator.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Also default to disabling dnn float debugging

Still don't quite know what I'm doing

Tim-Philipp Müller authored 1 year ago and Tristan Matthews committed 1 year ago

Would fail like:

Checking if "compiler supports ARMv7/AArch64 NEON intrinsics" : links: NO
Checking if "compiler supports ARMv7/AArch64 NEON intrinsics with -mfpu=neon" : links: YES
Checking if "compiler supports AArch64 NEON intrinsics" : links: NO
Checking if "compiler supports AArch64 NEON intrinsics with -mfpu=neon" : links: NO
Message: Compiler does not support AArch64 NEON intrinsics
../silk/meson.build:28:45: ERROR: Unknown variable "have_arm_intrinsics_or_asm".

since commit 08088411.

Signed-off-by: Doug Nazar <nazard@nazar.ca>

Xavier Claessens authored 4 years ago and Ralph Giles committed 4 years ago

meson.source_root() and meson.build_root() have been deprecated in
latest Meson release because they are a trap. They point to the root of
parent project instead of root of current subproject. Meson 0.56.0 added
meson.project_source/build_root() but it is just as easy to use
meson.current_source/build_dir() in the root meson.build file and avoids
bumping required meson version.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Tested on:
 - Linux/x86* with gcc
 - Android armv7 arm64 x86 x86_64 with clang
 - Windows x86 x86_64 with Visual Studio 2017
 - Windows x86 x86_64 with MinGW
 - macOS x86_64 with clang
 - iOS arm64 x86_64 with clang

Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>

https://gitlab.xiph.org/xiph/opus/-/merge_requests/13