Not observed yet (except when caused by a different bug), but "just in case"

Felicia Lim authored 8 years ago and Timothy B. Terriberry committed 8 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

When the energy is stable, we slightly bias energy quantization towards
the previous error to make the gain more stable (a constant offset is
better than fluctuations).

We reduce the bitrate by about 0.2% to 1% at low bitrate for the same quality.

Increasing the value at low rate seems to help a bit.

Otherwise, we risk having "temporal holes" in the HF that anti-collapse
can't always fill in.

It would trigger on the second frame of "S"s, causing holes in the spectrum

no dither

That was likely a mistake from a misunderstanding on the SILK bit allocation

Hybrid CBR now simply forces the SILK CBR rate to the "target" value. Also,
we're getting rid of the -2 kb/s offset for CBR, which appeared to be harmful.
In the case of hybrid constrained VBR, the cap is computed in the same way
as the target.

Koen Vos authored 8 years ago and Jean-Marc Valin committed 8 years ago

more conservative scaling of LTP corrs; remove assert that checks for negative residual energy; discard CB entries leading to such negative energies