Thomas Daede authored 2 years ago and Jean-Marc Valin committed 1 year ago

The version in the most recent draft has shipped in Firefox,
Chromium, and FFmpeg for several years and is quite stable.

Normally we would consider bumping the version field for the
dOps box, however as far as I know no incompatible version of
the box has ever been deployed, so I propose leaving it as is.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

luzpaz authored 1 year ago and Jean-Marc Valin committed 1 year ago

Found using `codespell -q 3 -L caf,highe,inlin,nd,ordert,shft`

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Claudio Saavedra authored 2 years ago and Ralph Giles committed 1 year ago

It's been deprecated for decades and in Debian system it's starting
to print warnings. Just use grep -F instead.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Xavier Claessens authored 4 years ago and Ralph Giles committed 4 years ago

meson.source_root() and meson.build_root() have been deprecated in
latest Meson release because they are a trap. They point to the root of
parent project instead of root of current subproject. Meson 0.56.0 added
meson.project_source/build_root() but it is just as easy to use
meson.current_source/build_dir() in the root meson.build file and avoids
bumping required meson version.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Tested on:
 - Linux/x86* with gcc
 - Android armv7 arm64 x86 x86_64 with clang
 - Windows x86 x86_64 with Visual Studio 2017
 - Windows x86 x86_64 with MinGW
 - macOS x86_64 with clang
 - iOS arm64 x86_64 with clang

Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>

https://gitlab.xiph.org/xiph/opus/-/merge_requests/13

willson-chen authored 5 years ago and Ralph Giles committed 4 years ago

Add newer source directories to the destdir file tree so we
can include all sources referenced from opus_sources.mk.

Signed-off-by: Ralph Giles <giles@thaumas.net>

willson-chen authored 4 years ago and Ralph Giles committed 4 years ago

[[ ]], the compound command is not supported by all
shell interpreter. [ ], the buildin command is more
common.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Silence a gcc warning by checking the return value of the fread()
call instead of the feof() guard. This prevents an infinite loop
in the case of a read error. Otherwise, when end-of-file is reached
fread() will certainly return a smaller number of elements read
than requested, so both cases are handled now.

Add a comment to clarify that we're dropping a partial frame on
purpose to keep the code simple.

Also add more braces around conditional bodies for less error-prone
style.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The simple codec round-trip example file in the doc directory
opens an input and output pcm file. It was working fine on
POSIX systems, but not on Windows, which treats text files
differently.

This is confusing in a example, so it's better to add an
explicit binary flag to the fopen() calls. This does nothing
on unix-like systems, but should make the example work for
developers on Windows.

Thanks to Wavesonics who reported this on irc.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

- Switch to 'Opus' file type identification.
- Revise channel mapping to better support ambisonics.

Ricardo Constantino authored 8 years ago and Ralph Giles committed 8 years ago

Remove version.mk and references to it in the repo.

genversion.bat will now generate the same version strings as
update_version script, i.e. without 'v' prefix and without a
fallback if git archive is used.

If run from a release tarball it'll use package_version,
like configure. If run from a git repo, it will use the same
'git describe' with '-dirty' as update_version.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Different distributions of doxygen have different default
values of HAVE_DOT setting, so we need to pick a specific
setting to avoid 'missing dot' warnings on some platforms.

Doxygen uses it to generate inclusion graphs for our various
header files, which is somewhat useful, but not essential.
We therefore enable dot if it's present (usually through
the parent graphviz package) but disable it if it's not
available, silencing the warning, but not giving uniform
results.

Thanks to RiCON for reporting this.

Generated by newer versions of Doxygen when built with sqlite3.

Thanks to Barry for proposing specific text for the changes.

Ralph Giles correctly points out that the sequence number field in
 Ogg pages starts couting at 0, so counting from 1 in the diagram
 might be confusing.