Rather than repeating the code to iterate through extensions in
 three different places, each with slight differences, different
 edge cases, different error handling, etc., create an iterator
 that can be used everywhere.

Nam Se Hyun authored 6 months ago and Tristan Matthews committed 6 months ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Test multiple buffer lengths and ensure we do not write past the
 end of the provided buffer.

The function takes an opus_int32 *, but we were passing the address
 of an int, which might not be the same.
This is only likely to affect platforms with a 16-bit int.

Without this check, a DRED extension encoded with an invalid frame
 number would still be used, potentially with a surprisingly large
 dred_frame_offset.

With an 8+ MB packet it is possible to craft an extension length
 that would overflow, bypassing the checks to ensure the extension
 data remains inside the packet.
This patch fixes that and adds a test for it.

Blaine Wood authored 10 months ago and Jean-Marc Valin committed 10 months ago

Only include floating point inner product when OPUS_FIXED_POINT is disabled.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Retraining a new model so that we have a matching .pth file.
Also, discarding more data on init to get better randomization.

Now used for fargan instead of LPCNet

dvosully authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Malcolm Nixon authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Should fix the few cases where the PLC would create voice frames
that shouldn't be there.

Marcus Asteborg authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Thomas Daede authored 2 years ago and Jean-Marc Valin committed 1 year ago

The version in the most recent draft has shipped in Firefox,
Chromium, and FFmpeg for several years and is quite stable.

Normally we would consider bumping the version field for the
dOps box, however as far as I know no incompatible version of
the box has ever been deployed, so I propose leaving it as is.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Xavier Claessens authored 1 year ago and Jean-Marc Valin committed 1 year ago

It is much less error prone because Meson can detect dependencies
automatically. As bonus Meson will also generate the opus-uninstalled.pc
file.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Timothy B. Terriberry authored 1 year ago and Jean-Marc Valin committed 1 year ago

Apple uses different __clang_major__ version numbers than upstream,
 so our test did not work.
This caused compilation failures with, e.g., XCode 10.1, which
 reports __clang_major__ as 10 despite being forked from upstream's
 7.0 branch.

Fixes #2369

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Extracted from this MR from Marcus Asteborg:
!82

dependabot[bot] authored 1 year ago and Jean-Marc Valin committed 1 year ago

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.36 to 3.1.41.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.36...3.1.41

)

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Rudi Heitbaum authored 1 year ago and Jean-Marc Valin committed 1 year ago

fixes:
  ../meson.build:322:9: ERROR: Unknown variable "opus_arm_may_have_dotprod"

after:
  dotprod check passes through.

Checking if "compiler supports gcc-style inline assembly" compiles: YES
Checking if "assembler supports EDSP instructions on ARM" compiles: YES
Checking if "assembler supports ARMv6 media instructions on ARM" compiles: YES
Checking if "assembler supports NEON instructions on ARM" compiles: YES
Checking if "assembler supports DOTPROD instructions on ARM" compiles: NO
Program perl found: YES (/usr/bin/perl)
Fetching value of define "__APPLE__" : (undefined)
Checking if "compiler supports ARMv7/AArch64 NEON intrinsics" : links: YES
Checking if "compiler supports AArch64 NEON intrinsics" : links: NO
Checking if "compiler supports AArch64 NEON intrinsics with -mfpu=neon" : links: NO
Message: Compiler does not support AArch64 NEON intrinsics
Checking if "compiler supports AArch64 DOTPROD intrinsics" : links: NO
Checking if "compiler supports AArch64 DOTPROD intrinsics with -march=armv8.2-a+dotprod" : links: NO
Message: Compiler does not support AArch64 DOTPROD intrinsics

refer:
- https://community.arm.com/arm-community-blogs/b/tools-software-ides-blog/posts/exploring-the-arm-dot-product-instructions



test with:
armv7ve-none-linux-gnueabihf-gcc test.c
/tmp/cc02sooK.s: Assembler messages:
/tmp/cc02sooK.s:32: Error: bad instruction `udot v0.4s,v1.16b,v2.16b'

aarch64-none-linux-gnu-gcc test.c
/tmp/ccnVi9Ec.s: Assembler messages:
/tmp/ccnVi9Ec.s:12: Error: selected processor does not support `udot v0.4s,v1.16b,v2.16b'

aarch64-none-linux-gnu-gcc -march=armv8.2-a+dotprod test.c

Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Rudi Heitbaum authored 1 year ago and Jean-Marc Valin committed 1 year ago

fixes:

testfile.c:3:11: warning: missing terminating " character
    3 |   __asm__(".arch armv5te
      |           ^
testfile.c:4:1: error: expected string literal before '.' token
    4 | .object_arch armv4t
      | ^
testfile.c:5:14: warning: missing terminating " character
    5 | qadd r3,r3,r3");
      |              ^

Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Rudi Heitbaum authored 1 year ago and Jean-Marc Valin committed 1 year ago

fix the following test in the meson.build

stderr:
testfile.c:6:34: error: expected ')' before '::' token
    6 |__asm__ (""::)
      |        ~  ^~
      |           )
testfile.c:6:37: error: expected ';' at end of input
    6 |__asm__ (""::)
      |              ^
      |              ;
-----------
Checking if "compiler supports gcc-style inline assembly" compiles: NO

refer:
- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41045



Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>