Only converted the ones that are really sure (not signal-dependent)
and that shouldn't add much run-time complexity

Since the last patch originally had them mangled (presumably by
 mailer, http server, or something else), let's just get rid of
 them.

Timothy B. Terriberry authored 13 years ago and Jean-Marc Valin committed 13 years ago

b24e5746 introduced changes to LastGainIndex which broke
 conditional coding for side frames after a mid-only frame (i.e.,
 in a 60 ms frame where the side is coded, not coded, then coded
 again).
These rules were a mess in general, however, because the side
 channel state kept a different nFramesDecoded count from the mid
 channel state, and had no way to tell if the prior side frame was
 coded.

This patch attempts to rationalize them by moving the conditional
 coding decision up to the top level, where all this information is
 available.
The first coded side frame after an uncoded side frame now always
 uses independent coding.
If such a frame is also not the first side frame in an Opus frame,
 then it doesn't include an LTP scaling parameter (because the LTP
 state is well-defined).

Gregory Maxwell authored 13 years ago and Jean-Marc Valin committed 13 years ago

There were assert failures for test cases with mode switching and LBRR enabled.
(some similar problems remain)

Tim identified that the assert was falsely firing while encoding LBRR frames but
the flag doesn't matter while encoding the bitstream it only actually matters in
silk/process_NLSFs.c.

Gregory Maxwell authored 13 years ago and Jean-Marc Valin committed 13 years ago

whitespace.

commit 5b64cf7c4d67af9050bc959996ef976ce6326888
Author: Jean-Marc Valin <jean-marc.valin@octasic.com>
Date:   Thu May 19 16:40:35 2011 -0400

    Fixes a few bugs introduced in the latest update

commit b91eb86025d2de3c4cf04f4fb1aa48a28ad676a3
Author: Timothy B. Terriberry <tterribe@xiph.org>
Date:   Thu May 19 16:12:02 2011 -0400

    build_draft.sh fixes

commit 0b10c30db7ad60ff7d4bfc1139bdb86e0543c035
Author: Jean-Marc Valin <jean-marc.valin@octasic.com>
Date:   Thu May 19 15:30:21 2011 -0400

    Fixes the draft build

commit 164424cded5978e657105104e171ac202dde5e5b
Author: Jean-Marc Valin <jean-marc.valin@octasic.com>
Date:   Thu May 19 15:00:23 2011 -0400

    Updated build system

commit 188d9fcba8c3a1b1ad67c67c430e1b37e3658a40
Author: Koen Vos <koen.vos@skype.net>
Date:   Thu May 19 17:14:57 2011 -0400

    SILK/Opus update

Koen Vos authored 13 years ago and Jean-Marc Valin committed 13 years ago

commit c44b37355295df2963daa724649ff1876b690488
Author: Jean-Marc Valin <jean-marc.valin@usherbrooke.ca>
Date:   Wed Apr 27 00:33:12 2011 -0400

    decoder size fix

commit 78f864e9ddacd94d03d717d79a6e606712e25edd
Author: Jean-Marc Valin <jean-marc.valin@usherbrooke.ca>
Date:   Tue Apr 26 23:26:14 2011 -0400

    Makefile fix

commit a0e884e463af88bcaa2f410ea8cc85e5bebd2c3b
Author: Jean-Marc Valin <jean-marc.valin@usherbrooke.ca>
Date:   Tue Apr 26 22:53:27 2011 -0400

    Making some progress

commit 9e30457f2199bba7b5e37bb577ff75dc85ba9306
Author: Koen Vos <koen.vos@skype.net>
Date:   Tue Apr 26 22:29:42 2011 -0400

    SILK update with stereo support

commit 7721daf733c6986cb2c2511c81e6fc14fea1ec6a
Author: Jean-Marc Valin <jean-marc.valin@octasic.com>
Date:   Mon Feb 28 16:00:52 2011 -0500

    Makefile.am update

commit 47dcc4edad849f57240b0c364036a378b5d22a9a
Author: Koen Vos <koen.vos@skype.net>
Date:   Mon Feb 28 15:46:23 2011 -0500

    SILK update (prefill, new LSF quant)

The byte buffer is now part of the range coder struct itself, and
 ec_{enc|dec}_tell have been replaced by a unified ec_tell() with
 no precision parameter.