NaN detection should now be able to catch values that would create NaNs
further down.

This also splits the rate adjustment between SILK and CELT (previous
code only changed SILK)

Still needs more tuning

Timothy B. Terriberry authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

These are all completely untested.

Timothy B. Terriberry authored 11 years ago and Jean-Marc Valin committed 11 years ago

Optimizing celt_pitch_xcorr()/xcorr_kernel() which also speeds up
FIRs, IIRs and auto-correlations

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Works by turning off pitch and energy prediction in CELT, while
setting first_frame_after_reset in SILK to disable pitch and LSF interpolation
and reduce LPC gain.

The problem was that forcing CELT-mode for low bitrate CBR was done too late,
after the encoder had decided to use SILK. This was causing redundancy
to be allocated because the encoder didn't realize it was going to keep
using CELT.

Padding is now handled by the repacketizer.

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

http://lists.xiph.org/pipermail/opus/2013-November/002372.html

This fixes an actual error in the downmix (using the float version even
for the int API), as well as a bunch of conversion warnings.

Stereo mode, stereo width, min bandwidth, VBR damping

Because it's indirectly used in the encoder (through the repackerizer).

The library really depends on all the little fixed point math functions
 being inlined in order to get acceptable performance. It turns out that
 it's very easy for someone to compile with optimization disable when
 twiddling cflags or cooking up their own build system.

Newer versions of MSVC are unhappy with the strategy of the build
 environment redefining "inline" (even though they don't support the
 actual keyword). Instead we define OPUS_INLINE to the right thing
 in opus_defines.h.

This is the same approach we use for restrict.

This fixes tansig_approx() to avoid crashing when the input is NaN.
The problem could only be triggered when calling the float API with
a float build at a complexity of 7 or more (i.e. analysis called).
Since the crash was due to an out-of-bound read (typically the index
is INT_MIN), it's unlikely to be exploitable in any other way than
causing a crash.