Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Add doc/trivial_example.c to the autotools build so we get
some minimal verification that the code compiles.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Silence a gcc warning by checking the return value of the fread()
call instead of the feof() guard. This prevents an infinite loop
in the case of a read error. Otherwise, when end-of-file is reached
fread() will certainly return a smaller number of elements read
than requested, so both cases are handled now.

Add a comment to clarify that we're dropping a partial frame on
purpose to keep the code simple.

Also add more braces around conditional bodies for less error-prone
style.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The simple codec round-trip example file in the doc directory
opens an input and output pcm file. It was working fine on
POSIX systems, but not on Windows, which treats text files
differently.

This is confusing in a example, so it's better to add an
explicit binary flag to the fopen() calls. This does nothing
on unix-like systems, but should make the example work for
developers on Windows.

Thanks to Wavesonics who reported this on irc.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Hector Martin authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Describe builds for the gitlab continuous integration
service runners. This does a trial build under both
autotools and cmake, so we get some coverage for changes
on that hosting platform.

After the same script in the vorbis and ogg projects.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Hua, Chunbo authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Nathaniel R. Lewis authored 4 years ago and Jean-Marc Valin committed 4 years ago

    - Fix typo in OPUS_USE_NEON description.

    - Set OPUS_PRESUME_NEON for iOS platforms as all armv7 and higher
      iOS devices support NEON.

    - Fix detection of aarch64 for OPUS_CPU_ARM and adding sources from
      celt_sources_arm. (previously would miss armcpu.c and arm_celt_map.c)

    - Change "armv7-a" to "arm" in MATCHES checks against
      CMAKE_SYSTEM_PROCESSOR as systems like the RPi3 report as
      "armv7l".

    - Rename OPUS_MAY_SUPPORT_NEON to OPUS_MAY_HAVE_NEON as this name is
      used everywhere else in the CMake build system. Without this,
      runtime capability detection is broken on aarch64.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 4 years ago

cmake - intinsics fixes, only compile SSE source with SSE flags on non-windows when target use runtime check (GH #154). For windows we only use /arch flag when target is presumed to support SSE to avoid AVX function pollution (GH #132).

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

willson-chen authored 5 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

evpobr authored 5 years ago and Jean-Marc Valin committed 4 years ago

Install include directory must be `include/opus`, not `include`.

Old path is still here for compatibility.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Nathaniel R. Lewis authored 5 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Niclas Olmenius authored 5 years ago and Jean-Marc Valin committed 4 years ago

When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Reland "Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision"

This flag was modified after calling the Silk encoder function. This commit corrects that behavior by introducing those modifications before calling the Silk encoder.

Slightly modified comments by Felicia Lim

Signed-off-by: Felicia Lim <flim@google.com>

Revert "Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision"

This reverts commit ea3b30f9.

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision

This flag was modified after calling the Silk encoder function. This commit corrects that behavior by introducing those modifications before calling the Silk encoder.

Slightly modified comments by Felicia Lim

Signed-off-by: Felicia Lim <flim@google.com>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

This reverts commit 4f5557c3.

Signed-off-by: Felicia Lim <flim@google.com>

DeadSix27 authored 5 years ago and Jean-Marc Valin committed 5 years ago

The old variable `OPUS_LIBRARY_VERSION`, does not line up with what's used in autoconf, which uses the PACKAGE_VERSION instead, which in turn lines up with what version the projects `opusfile` and `libsndfile` check for, for example.
While at it, I also cleaned up the accidental double up in code.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Nathaniel R. Lewis authored 5 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Davide Beatrici authored 5 years ago and Jean-Marc Valin committed 5 years ago

From https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

:

"Global flag to cause add_library() to create shared libraries if on.

If present and true, this will cause all libraries to be built shared unless the library was explicitly added as a static library. This variable is often added to projects as an option() so that each user of a project can decide if they want to build the project using shared or static libraries."

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Gustaf Ullberg authored 5 years ago and Felicia Lim committed 5 years ago

Signed-off-by: Felicia Lim <flim@google.com>

The data pointer could be null in the case of DTX or packet loss.

Thanks to Ray Essick

Marcus Asteborg authored 5 years ago and Ralph Giles committed 5 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>