Skip to content
Snippets Groups Projects
Commit 72358ce5 authored by Petter Reinholdtsen's avatar Petter Reinholdtsen
Browse files

Avoid undefined shifting of negative number in rate.c.

It is undefined what left-shifting a negative number should do, and the
compiler do not like trying to shift the -64 value 57 bits to the left.

Changed the definition of OC_Q57() to left shift one bit and
use multiplication, to change the operatoin to a well defined one.
Patch from Timothy B_ Terriberry.

This get rid of this clang message:

>  ../../lib/rate.c:746:15: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
>      log_scale=OC_Q57(-64);
>                ^~~~~~~~~~~
>  ../../lib/mathops.h:134:38: note: expanded from macro 'OC_Q57'
>  #define OC_Q57(_v) ((ogg_int64_t)(_v)<<57)
>                      ~~~~~~~~~~~~~~~~~^

Fixes #2321
parent 4b90527c
No related branches found
No related tags found
No related merge requests found
Pipeline #6178 passed
......@@ -131,7 +131,7 @@ int oc_ilog64(ogg_int64_t _v);
*/
# define OC_STATIC_ILOG_64(_v) (OC_STATIC_ILOG6((ogg_int64_t)(_v)))
#define OC_Q57(_v) ((ogg_int64_t)(_v)<<57)
#define OC_Q57(_v) ((_v)*((ogg_int64_t)1<<57))
#define OC_Q10(_v) ((_v)<<10)
ogg_int64_t oc_bexp64(ogg_int64_t _z);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment