GitLab

This line:

'''storage=(char *)_ogg_calloc(1,size);'''

at following code snippet, has memory leak. (huffdec.c) pls check.

/Unpacks a set of Huffman trees, and reduces them to a collapsed representation. _opb: The buffer to unpack the trees from. _nodes: The table to fill with the Huffman trees. Return: 0 on success, or a negative value on error./ int oc_huff_trees_unpack(oc_pack_buf *_opb, oc_huff_node *_nodes[TH_NHUFFMAN_TABLES]){ int i; for(i=0;i<TH_NHUFFMAN_TABLES;i++){ oc_huff_node nodes[511]; char *storage; size_t size; int ret; /Unpack the full tree into a temporary buffer./ ret=oc_huff_tree_unpack(_opb,nodes,sizeof(nodes)/sizeof(*nodes)); if(ret<0)return ret; /Figure out how big the collapsed tree will be./ size=oc_huff_tree_collapse_size(nodes,0); storage=(char *)_ogg_calloc(1,size); if(storage==NULL)return TH_EFAULT; /And collapse it./ _nodes[i]=oc_huff_tree_collapse(nodes,&storage); } return 0; }