Skip to content

Avoid creating a Cairo buffer if all telemetry options are set to 0.

Zebediah Figura requested to merge zfigura/theora:master into master

GStreamer's "theoradec" element exposes libtheoradec telemetry options to the user, but if none are set it still calls th_decode_ctl(), setting the relevant options to 0. This causes the "telemetry" path to be enabled, such that we still create a Cairo image and perform YUV/RGB translation, which is very slow.

I'm not sure this is a bug per se, but it seems like an optimization worth performing to only create a Cairo image if any telemetry options are actually enabled (i.e. nonzero).

Merge request reports