CVE-2008-1420 patch breaks decoding of 1.0beta1 files
libvorbis is no longer able to play files encoded with the 1.0beta1 encoder because of the changes made to res0.c in changeset [14598]. This was initially filed in the Debian BTS because I didn't realize the same change had been made to the libvorbis trunk: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504421
A sample file is attached to that report.
I added some debugging statements and found it was the final (partvals != entries) check failing:
partvals (784) != entries (900); origdim=2 partitions=28http://xiph.org/vorbis/ states "The bitstream format for Vorbis I was frozen Monday, May 8th 2000. All bitstreams encoded since will remain compatible with all future releases of Vorbis." It looks like 1.0beta1 was released on or after 2000-05-12, so files encoded by it should still be decodable.