The one place for your designs
To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.
uninitialized variables in lib/psy.c:bark_noise_hybridmp()
floats A, B and D are not initialized to 0.0 (would 0.0 be OK value, anyways?).
when I initialized them to 0.0 in the beginning of bark_noise_hybridmp,
libvorbis produces different output from the same input.
I can't hear much difference, but there is a difference.
for example, encoding fatboy.wav with quality 5.0:
-rw-rw---- 1 safari safari 153883 2003-09-14 03:26:55.000000000 +0300
fat-q5-psy.ogg
-rw-rw---- 1 safari safari 153900 2003-09-14 03:25:34.000000000 +0300
fat-q5.ogg
(-psy is the version with A, B, D initialized...)
$ cmp -l fat-q5.wav fat-q5-psy.wav
23619 63 62
23623 44 42
23627 235 232
23631 370 367
23635 215 217
23639 153 160
23643 357 367
23647 244 252
23651 254 255
23655 333 324
23659 262 243
...