Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Vorbis Vorbis
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.Org
  • VorbisVorbis
  • Issues
  • #682

Closed
Open
Created Jul 07, 2005 by Daniel Stenberg@daniel.stenberg

possible use of uninitialized variable in Tremor/sharedbook.c

Building Tremor with gcc 4.0 identified this possible flaw (and the Tremor svn repo seems to still have it done this way). This change was just committed in the Rockbox project's CVS tree. (There doesn't seem to be any component in the bug tracker for Tremor so I set it to libvorbis...)

--- sharedbook.c        28 Feb 2005 20:55:30 -0000      1.2
+++ sharedbook.c        7 Jul 2005 08:23:21 -0000       1.3
@@ -211,7 +211,7 @@
          int indexdiv=1;
          for(k=0;k<b->dim;k++){
            int index= (j/indexdiv)%quantvals;
-           int point;
+           int point=0;
            int val=VFLOAT_MULTI(delta,delpoint,
                                 abs(b->quantlist[index]),&point);

@@ -245,7 +245,7 @@
          int         lastpoint=0;

          for(k=0;k<b->dim;k++){
-           int point;
+           int point=0;
            int val=VFLOAT_MULTI(delta,delpoint,
                                 abs(b->quantlist[j*b->dim+k]),&point);
Assignee
Assign to
Time tracking