When SILK decided not to use the desired bandwidth, the redundancy
could be encoded at the desired bandwidth rather than at the actual
bandwidth used.

No longer encoding the redundancy flag for SILK since we can infer
redundancy from the length of the frame. Also, we skip encoding the
flag for hybrid mode when we know the decoder will not read it.

Also not fuzzing the mode when it's forced

We now make sure that side is given >0 bits when it isn't disabled.

1) averaging the output of the left and right resampling states when
   switching to mono
2) averaging the the delay buffers from left and right when switching

Adds SILK delay compensation that depends on encode and decode sampling
rate, as well as SILK internal coding rate. This ensures that the SILK
part of Opus is always in sync with the CELT part no matter what the
sampling rates are. It also increases the resampling delay to 1.15 ms
(was previously 0.48 ms).

Timothy B. Terriberry authored 13 years ago and Jean-Marc Valin committed 13 years ago

This patch
 * expands sections on LPC and LTP synthesis into something that can
    actually be implemented
 * fixes an error in the excitation reconstruction
 * reverts an erroneous simplification of the subframe gain
    decoding, and
 * updates the LPC gain limiting description to reflect the new,
    more accurate approach for computing the reflection
    coefficients.
It also includes a number of general clean-ups, such as
 * correcting the description of the sample rates various pieces
    run at (e.g., we can decode directly to rates other than 48 kHz)
 * the usage of "sampling rate" vs. "sample rate"
 * capitalization consistency in TOC titles, and
 * better selection of which sections appear in the TOC.

Koen Vos authored 13 years ago and Jean-Marc Valin committed 13 years ago

Simplifies mono/stereo switching in SILK
Fixes a quantization mismatch between encoder and decoder
Constrains the pitch lags in the same way in the encoder and decoder

Koen Vos authored 13 years ago and Jean-Marc Valin committed 13 years ago

Fixes a mono-stereo switching glitch and fixes a side prediction
bug where coding side would result in worse panned-mono behaviour

Gregory Maxwell authored 13 years ago and Jean-Marc Valin committed 13 years ago

There were assert failures for test cases with mode switching and LBRR enabled.
(some similar problems remain)

Tim identified that the assert was falsely firing while encoding LBRR frames but
the flag doesn't matter while encoding the bitstream it only actually matters in
silk/process_NLSFs.c.

custom modes.

More assert updates, make the initialization in silk_warped_autocorrelation_FLP more explicit to make tools happy, and allow resetting to auto with OPUS_SET_FORCE_CHANNELS.

We now reset the CELT state when swithing to hybrid and we "drain"
the CELT MDCT overlap when switching away from hybrid.

Gregory Maxwell authored 13 years ago and Jean-Marc Valin committed 13 years ago

Add the noreturn attribute on the assert functions to aid static analysis, improve test_repacketizer error handling, and silence 19 clang static analysis errors with additional assertions.

Gets rid of some more glitches caused by the decoder resampler

The redundancy_bytes<0 test always fails because of the ec_tell(&dec)+29 test above.

Conflicts:
	src/opus_encoder.c

Delaying stereo->mono switching decisions so that SILK can do a smooth
downmix. Also, wrote proper float/fixed code for the hybrid variable
stereo collapse, including a smooth downmix for stereo<->mono switching

Fix bug in the OPUS_GET_APPLICATION_REQUEST ctl and also add a bunch of set ctl range checking and improve encoder/decoder error code consistency.

Gregory Maxwell authored 13 years ago and Jean-Marc Valin committed 13 years ago

As of commit 44203907 all celt bands N>1 are even, including custom modes. In light of this, remove some pointless tests.

Jean-Marc Valin authored 13 years ago and Jean-Marc Valin committed 13 years ago

LPC_inverse_pred_gain_QA() was failing to detect unstable filters
because of insufficient numerical precision. Precision was increased
to Q24 for LPC coefs and the reciprocal now uses all the precision
available (variable shift right from the start).

(Fs_kHz is always 8/12/16 in Opus and also enforced by the assert on line 112)