1. 21 Sep, 2016 3 commits
  2. 16 Sep, 2016 1 commit
    • Timothy B. Terriberry's avatar
      Fix MSVC warnings. · d0c82543
      Timothy B. Terriberry authored
      Some of these pointed to real potential overflows (given arbitrary
       inputs by the calling application).
      I was sad about stripping const qualifiers from the struct addrinfo
       pointers, but MSVC seems to erroneously think that an array of
       pointers to constant data is itself a pointer to constant data (or
       maybe that it is not compatible with a const void *?), and
       converting the memmove()s to for loops triggered an erroneous
       warning about out-of-bounds array accesses in gcc (but on only one
       of the two identical loops).
  3. 29 Jul, 2016 4 commits
  4. 27 Jul, 2016 4 commits
  5. 08 Jul, 2016 2 commits
  6. 06 Jul, 2016 4 commits
  7. 04 Jul, 2016 7 commits
    • Timothy B. Terriberry's avatar
    • Timothy B. Terriberry's avatar
      Fix free with uninitialized data in opus_tags_parse(). · 72f4f8a6
      Timothy B. Terriberry authored
      If the parsing fails before all comments are filled in, we will
       attempt to free any binary metadata at the position one past the
       last comment, which will be uninitialized.
      Introduced in commit 0221ca95.
    • Timothy B. Terriberry's avatar
      Add missing NULL check to opus_tags_parse(). · bd607f5c
      Timothy B. Terriberry authored
      According to the API, you can pass in a NULL OpusTags object to
       simply check if the comment packet is valid, without storing the
       parsed results.
      However, the additions to store binary metadata in commit
       0221ca95 did not check for this.
      Fixes Coverity CID 149873.
    • Timothy B. Terriberry's avatar
      Fix NULL check in opus_tags_add_comment(). · 66a8c158
      Timothy B. Terriberry authored
      In 0221ca95 the allocation result went from being stored
       directly in "_tags->user_comments[ncomments]" to being stored in
       the temporary "comment".
      However, the NULL check for allocation failure was not updated to
      This meant this function would almost always fail, unless you had
       added binary metadata first.
      Fixes Coverity CID 149874.
    • Timothy B. Terriberry's avatar
      Fix skipping logic for multiplexed non-Opus pages. · 78cd9bcf
      Timothy B. Terriberry authored
      This bug appears to have been present since the original code
      This was a "clever" rearrangement of the control flow from the
       _fetch_and_process_packet() in vorbisfile to use a do ... while(0)
       instead of a "while(1)".
      However, this also makes "continue" equivalent to "break": it does
       not actually go back to the top of the loop, because the loop
       condition is false.
      This bug was harmless, because ogg_stream_pagein() then refuses to
       ingest a page with the wrong serialno, but we can simplify things
       by fixing it.
      The "not strictly necessary" loop is now completely unnecessary.
      The extra checks that existed in vorbisfile have all been moved to
       later in the main loop, so we can just continue that one directly,
       with no wasted work, instead of embedding a smaller loop inside.
      Fixes Coverity CID 149875.
    • Timothy B. Terriberry's avatar
      Note small inaccuracy in bitrate tracking. · 73909d7d
      Timothy B. Terriberry authored
      In the non-seekable case, we'll undercount some bytes at the start
       of a new link.
      Still thinking about the best way to address this, but leaving a
       comment so I don't forget.
    • Timothy B. Terriberry's avatar
      Should a BOS page with no packets be an error? · 3abc3541
      Timothy B. Terriberry authored
      Going with "no" for now, but leave a reminder in the source code
       that this is a debatable question.
  8. 26 Jun, 2016 1 commit
  9. 19 Jun, 2016 1 commit
  10. 16 Jun, 2016 2 commits
  11. 01 Jun, 2016 2 commits
  12. 06 Jan, 2016 1 commit
  13. 05 Jan, 2016 2 commits
  14. 04 Jan, 2016 1 commit
  15. 01 Jan, 2016 5 commits
    • Ralph Giles's avatar
      mingw: Add a package target. · 51de1ced
      Ralph Giles authored
      This does the basics to build the win32 binary release zipfile
      for testing. Doesn't sign or version it properly.
    • Ralph Giles's avatar
    • Ralph Giles's avatar
      mingw: Bump docker build to Fedora 21. · e17a2bfb
      Ralph Giles authored
      The version of mingw in Fedora 21 works as well.
      This is the first version to depend on libwinpthread.
      Also add an autogen.sh invocation which caused the previous
      build to fail after the 'make check' barrier was removed.
    • Ralph Giles's avatar
      mingw: remove 'make check' steps. · fa43e4da
      Ralph Giles authored
      This requires wine to run the windows executables, which is a
      pretty heavy dependency. Better to do without for now.
    • Ralph Giles's avatar
      mingw: Add a Dockerfile describing cross build. · f358633e
      Ralph Giles authored
      For some reason, when I cross-compile opusfile on Fedora 23,
      I get example binaries with exit immediately without error.
      Building them on Fedora 20 (in a docker container) produced
      working binaries. Until we figure out what the bug is, include
      this for convenience.
      The build doesn't actually work because of the 'make check'
      steps in the Makefile, which require wine.