This is the less-surprising behavior and will hopefully
result in fewer corner case bugs (e.g. losing gain
after seeking). This commit also updates the documentation.

This CTL was requested by Nicolas George for FFmpeg.

Gregory Maxwell authored 12 years ago and Jean-Marc Valin committed 12 years ago

In places where an ignored return or a null-arg is a sure indication
of a bug add the GCC warning attributes. The null arg annotation
is not enable for Opus itself because it will cause the compiler
to optimize out some null checks. I don't trust our callers
quite that much.

This was a problem for static builds

Unlike the other headers, opus_multistream.h didn't declare
itself to be C code, causing confusing errors when the caller
tries to use the functions from C++.

This reverts commit 9f407afa.

Also added 3rd clause to "master" COPYING file

See http://www.ietf.org/mail-archive/web/codec/current/msg02833.html
Still more changes to come

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 12 years ago

The parameter descriptions look like they were copied
from encoder_create. Update them for the decode side
and repeat the clarifications about what sample rates
are allowed and what they mean.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 12 years ago

Also fixes a minor typo.

Doxygen is smart enough to insert a period if the paragraph
before the @see directive, which starts a new section, doesn't
have one. Unfortunately it's not smart enough to convert a
comma to a period. So while the "description, @see foo" idiom
used for the CTL documentation scans well in the header file,
the Doxygen output end up with "description,.\n".

Minimal change to remove the offending commas.

opus_decode() takes a sixth 'enable_fec' option. Naive invocations
shoudl set this to zero.

Gregory Maxwell authored 13 years ago and Jean-Marc Valin committed 13 years ago

Also change the packet length in the API from int to opus_int32
because repacketized frames are able to go beyond 32767 bytes
in size.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

C reserves identifiers of the from _[A-Z]+ and we have a number of
those in the code. This patch renames the various function arguments,
MACROS and preprocessor symbols to avoid the reserved form.

It also removes the CHANNELS() macro altogether. This was a
minor optimization for TI DSP to force a mono-only build,
as were the associated local 'const' versions. Since stereo
support is manditory, it wasn't worth keeping.

Thanks to John Ridges for raising the issue, and Jean-Marc Valin
and Greg Maxwell for reviewing the changes.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

We use macros to encapsulate the appropriate type and size
information for the different CTL requests, but the macros
still need to be used with the _ctl() function call and an
encoder or decoder instance structure. As such, just listing
the macro defines is confusing. Adding some examples outside
the OpusEncoder overview page should help with this.

Also document that OPUS_SET_APPLICATION can take
OPUS_APPLICATION_RESTRICTED_LOWDELAY.

Let's put it back in if/when we have a clearer view of voice/music detection