1. 02 Aug, 2017 7 commits
    • Timothy B. Terriberry's avatar
      Minor win32 warning fix. · dc27cf17
      Timothy B. Terriberry authored
      op_fopen() and op_freopen() declare these arguments as non-NULL,
       so when building with mingw, the compiler reasonably complains
       when we check to see if they're NULL.
      We could remove the OP_ARG_NONNULL tags, but the behavior of
       _wopen/_wfreopen appears to be to crash on NULL for either
      On Linux, the behavior appears to be to handle a NULL path (fopen
       returns NULL with errno set to EFAULT, and freopen returns the
       passed FILE * with errno set to EFAULT), but crash on a NULL mode.
      Keeping the OP_ARG_NONNULL tags promises that passing NULL results
       in undefined behavior, which is at least consistent with the
       behavior being different on different platforms.
      It's also consistent with the ABI promises of previous releases,
       which compilers linking against libopusfile might have taken
       advantage of.
    • Ralph Giles's avatar
      Update soname for the opusfile 0.9 release. · d9bbf207
      Ralph Giles authored
      The return type of op_serialno changed from ogg_uint32
      to opus_uint32, but those types should be abi compatible.
    • Ralph Giles's avatar
      mingw: Update to opus 1.2. · 5f884d4f
      Ralph Giles authored
      New release of the codec reference implementation.
    • Ralph Giles's avatar
      mingw: Use an https url for downloading libogg. · d36aab71
      Ralph Giles authored
      downloads.xiph.org recently got https support.
    • Ralph Giles's avatar
      Fix a formatting nit. · d45bd3bf
      Ralph Giles authored
    • Thomas Daede's avatar
      Disable building latex documentation on ci. · e46f46a5
      Thomas Daede authored
      The documentation currently fails to build on Jenkins due to
      hyperref and doxygen not playing nicely with each other on
      Debian Stretch.
    • Timothy B. Terriberry's avatar
      Print a useful error when pkg-config is missing · 2521a7d8
      Timothy B. Terriberry authored
      Without this check, the PKG_CHECK_MODULES() macro remains
      unexpanded, which gives a syntax error when the shell reaches that
      point in the configure script, even for checks which are disabled
      (e.g., the OpenSSL check when using --disable-http).
      Instead, explicitly check for pkg-config and give the user useful
      advice on how to solve the problem if it's not found.
      Thanks to eXpl0it3r for reporting a problem for which installing
      pkg-config turned out to be the solution.
  2. 07 Jul, 2017 2 commits
    • Timothy B. Terriberry's avatar
      Improve source/stream terminology consistency · c59d42b6
      Timothy B. Terriberry authored
      We inherited the term "source" from vorbisfile's "datasource", but
       were using it interchangeably with stream.
      At least one user did not even realize the that the _source
       parameter passed to op_open_callbacks() was the same as the
       _stream parameter taken by those callbacks, which is reasonable
       because we never said so.
      Consistently use "stream" instead of "source" in both the
       documentation and the code.
    • Timothy B. Terriberry's avatar
      Minor documentation cross-reference. · 881a54da
      Timothy B. Terriberry authored
      Let people reading about the output_gain field know how to change
       the way it gets applied.
  3. 17 Jun, 2017 1 commit
  4. 07 Jun, 2017 3 commits
    • Ralph Giles's avatar
      Propogate openssl CFLAGS to the opusurl build. · 1fbe0cd1
      Ralph Giles authored
      We added DEPS_CFLAGS to the general build, but opusurl
      has an additional dependency on openssl. If the headers
      were outside the normal search path, configure could
      succeed but then the build would fail on http.c.
      We need to add URL_DEPS_CFLAGS to that specific target.
    • Ralph Giles's avatar
      mingw: Drop fedora from dist version. · 6a033a83
      Ralph Giles authored
      I think it's less confusing for most users to omit this. I added
      it so I could distinguish the docker-hosted cross package from
      others, but it's a distraction for people trying to use the
      resulting binaries.
    • Ralph Giles's avatar
      mingw: Query git for dist version. · 88a72642
      Ralph Giles authored
      We build from a git repo, so we can call `git describe` to
      generate a version number. When building from a tag, this
      should give us a clean release-versioned filename.
  5. 06 Jun, 2017 1 commit
  6. 26 May, 2017 1 commit
    • Ralph Giles's avatar
      Update mingw dependencies. · 5d38a3db
      Ralph Giles authored
      opus 1.1.5
      openssl 1.0.2l
      There's a newer branch (openssl 1.1.x) availabe now, but the
      build script needs changes to make it work. Stay on 1.0.2 for now.
  7. 24 May, 2017 2 commits
    • Timothy B. Terriberry's avatar
      Fix two compiler warnings. · 3b3b3e55
      Timothy B. Terriberry authored
      Thanks to Mark Harris for the report.
    • Timothy B. Terriberry's avatar
      Fix uninitialized free in tag parsing. · 529bd012
      Timothy B. Terriberry authored
      The tags have two possible representations of the binary suffix
      An implicit one: if comment_lengths and user_comments are NULL,
       then the length of the binary suffix data is 0 and the pointer to
       that data is also implicitly taken to be NULL.
      And an explicit one: if comment_lengths and user_comments are
       non-NULL, then comment_lengths[comments] and
       user_comments[comments] contains the length and pointer to the
       binary suffix data (where "comments" is the number of user
      The implicit one allows us to initialize a tags struct without
       doing any allocations, which ensures it always succeeds.
      op_tags_ensure_capacity() may upgrade the implicit representation
       to the explicit representation.
      However, when doing so, it stores the implicit (0, NULL) values
       in their new explicit locations at the end of the array assuming
       the requested capacity will become the new size.
      If the caller of op_tags_ensure_capacity() then fails before
       enlarging the array to that size, then comment_lengths and
       user_comments will be non-NULL, but the explicit locations for the
       binary suffix data for the _old_ size may not have been
      In particular, in opus_tags_parse_impl(), if there was exactly one
       comment, and any of the three checks at the start of the main loop
       failed, then the explicit locations for the binary suffix data
       would remain uninitialized, and the call to opus_tags_clear() in
       the caller would attempt to free them.
      For counts larger than 1, the extra line marked "Needed by
       opus_tags_clear()" will update the explicit location as the array
       grows, but with a count of 1 this line never gets a chance to run.
      This patch fixes the problem by making op_tags_ensure_capacity()
       promote the implicit representation to explicit at _both_ the old
       and new array sizes.
      We could have fixed up opus_tags_parse_impl() to do this instead,
       as suggested in the original bug reports, but doing it this way
       ensures that the tags are always in a valid state when
       op_tags_ensure_capacity() returns.
      Thanks to the Google AutoFuzz Team for the report.
      Fixes #2324
      Fixes #2325
  8. 19 May, 2017 7 commits
    • Timothy B. Terriberry's avatar
      Minor documentation fix. · 0adf7303
      Timothy B. Terriberry authored
      Clarify that the value returned by op_current_link() is strictly
       less than the value returned by op_link_count() for seekable
    • Timothy B. Terriberry's avatar
      Harmonize op_raw_total() and op_raw_seek() · 37f83754
      Timothy B. Terriberry authored
      op_raw_seek() will fail if you try to seek to a byte position
       beyond the end of the file.
      However, the "end" is defined in terms of _of->end, which is
       specifically the end of the last Ogg page found in the underlying
       source (excluding any trailing non-Ogg data).
      op_raw_total(_of,-1) returns the total size of the stream by using
       _of->end, but it was also subtracting the offset of the first Opus
       page in the first link.
      Since there might have been other Ogg streams concurrently
       multiplexed with the first Opus stream whose BOS pages appear
       first, or there might simply be non-Ogg junk at the start, that
       left the caller with no way to determine the valid range of byte
       offsets that could be passed to op_raw_seek().
      Instead, make op_raw_total() pretend the first link starts at
       offset 0, and explicitly document that it's what defines the range
       of valid values to op_raw_seek().
      This is how our own seeking_example.c was using it, anyway.
    • Timothy B. Terriberry's avatar
      Improve handling of holes (corrupt pages). · fd65b94f
      Timothy B. Terriberry authored
      Previously, when we encountered a hole (a gap in the page sequence
       numbers), we would save off all of the packets from the first page
       after the hole, but not timestamp them.
      That meant when they were actually decoded, op_pcm_tell() would
       report a timestamp of 0 until reaching the last packet on that
      Instead, handle holes just like a raw seek.
      We reset the granule position tracking, and attempt to timestamp
       packets backwards from the end of the page.
      If the first page after the hole is an EOS page, we just throw it
       away (rather than risk playing invalid samples due to incorrect
      We also throw away the first 80 ms of audio after a hole, to allow
       the decoder state to reconverge.
      This patch also updates the example to report the hole and
       continue decoding, rather than immediately stopping when a hole is
       encountered, in order to test the above features.
    • Timothy B. Terriberry's avatar
      Avoid operations linear in the number of links. · f83675eb
      Timothy B. Terriberry authored
      Just in case some bozo makes a chained stream with 272,389 links
       with 16 samples in each (coded at 16 Mbps, including overheads).
      This avoids quadratic behavior for simple straight-through
       playback: we no longer do a linear search on each chain boundary
       or each call to op_pcm_tell().
      N seeks with M chains still requires O(N*log(M)) work.
    • Timothy B. Terriberry's avatar
      Minor comment updates. · 21ebba38
      Timothy B. Terriberry authored
      No code changes.
    • Timothy B. Terriberry's avatar
      Use OpenSSL's hostname validation if available. · cc1fff58
      Timothy B. Terriberry authored
      As of version 1.0.2, OpenSSL can finally do automatic hostname
       validation for us.
      Their implementation is likely to have received much better review
       than ours, and there are other good reasons to prefer it, so use it
       when we can.
    • Timothy B. Terriberry's avatar
      Fix two minor errors in hostname validation. · 0a94cf8f
      Timothy B. Terriberry authored
      RFC 6125 says that if the host is an IP address, a subjectAltName of
       type iPAddress must (no 2119 caps) be present and must be used.
      We would still fall back to checking the Common Name if no
       subjectAltName was present.
      https://marc.info/?l=openssl-dev&m=139617145216047&w=2 interprets
       RFC 6125 to say that if the host is a DNS name, but the certificate
       only contains a subjectAltName of type iPAddress, then we should
       still fall back to checking the Common Name.
      We would only check the Common Name if there was no subjectAltName
       of any type.
      Restructure the hostname validation to check IP addresses up-front
       and fall back to checking the Common Name in the proper cases.
  9. 10 Mar, 2017 1 commit
  10. 08 Feb, 2017 1 commit
  11. 08 Nov, 2016 1 commit
    • Ralph Giles's avatar
      mingw: Don't use deltarpm reconstruction. · 6a08376d
      Ralph Giles authored
      The fedora docker images ship without the necessary metadata
      to reconstruct rpm packages from installed data, so attempting
      to download delta rpm packages when updating the system just
      wastes time and bandwidth.
  12. 04 Nov, 2016 7 commits
  13. 28 Sep, 2016 1 commit
  14. 21 Sep, 2016 4 commits
  15. 16 Sep, 2016 1 commit
    • Timothy B. Terriberry's avatar
      Fix MSVC warnings. · d0c82543
      Timothy B. Terriberry authored
      Some of these pointed to real potential overflows (given arbitrary
       inputs by the calling application).
      I was sad about stripping const qualifiers from the struct addrinfo
       pointers, but MSVC seems to erroneously think that an array of
       pointers to constant data is itself a pointer to constant data (or
       maybe that it is not compatible with a const void *?), and
       converting the memmove()s to for loops triggered an erroneous
       warning about out-of-bounds array accesses in gcc (but on only one
       of the two identical loops).