Yushin Cho authored 5 years ago and Yushin Cho committed 5 years ago

Because it has been quite confusing, when its sole effect is
to decide whether doing pixel reconstruction or not.

Romain Vimont authored 5 years ago and Thomas Daede committed 5 years ago

Encode the single-tile frame using a single-tile TileBlocks.

Romain Vimont authored 5 years ago and Thomas Daede committed 5 years ago

Encode the frame as a single tile using the new tiling structures.

Adrien Maglo authored 5 years ago and Thomas Daede committed 5 years ago

This allows to call the right ASM SAD implementation.

With tiling, the lifetime of CDFContext will exceed that of
ContextWriter (which will exist only during tile encoding).

The resulting CDFContext must be read to be (possibly) copied into the
FrameState.

Therefore, make ContextWriter only reference it (instead of taking
ownership).

With tiling, the lifetime of FrameBlocks will exceed that of
BlockContext (which will exist only during tile encoding).

Therefore, create it separately, and make BlockContext reference it.

They have different paths and ASM functions.

FrameBlocks is part of the BlockContext structure. Many functions which
used only the FrameBlocks (but not the other BlockContext fields)
received a reference to the whole BlockContext as parameter.

FrameBlocks will survive tiles-encoding: it will be accessed through a
tiled version for each tile, then frame-wise after all tiles are
encoded.

However, BlockContext will only be used tile-wise: there will be one
instance per tile, destroyed once the tile is encoded. Therefore,
frame-wise functions may not receive the whole BlockContext anymore
(all tile-specific BlockContext instances won't exist anymore).

Like previous commits did for BlockOffset and SuperBlockOffset.

BlockOffset has a size of 128 bits (the same as a slice), and is
trivially copyable, so make it derive Copy.

Once it derives Copy, clippy suggests to never pass it by reference:
<https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref>

So pass it by value everywhere to simplify usage.

In particular, this avoids lifetimes bounds where not necessary (e.g.
in get_sub_partitions()).

See <https://github.com/xiph/rav1e/pull/1126#issuecomment-474532123>.

The function get_sad() was called with block width and block height
parameters swapped.

As a consequence, in tests, associate the precomputed SAD values to the
transposed block size.

In order to support both u8 and u16 for plane components, make the Plane
structure generic over the component type. As a consequence, many other
structures and functions also become generic.

Some functions are not u8-compatible yet, although they have been make
generic over the component type to make the compilation work. They
assert that the size of the generic parameter is 16 bits wide.

For this reason, the root context structure is unconditionally created
as Context<u16> for now.

Automated by running `cargo fix --edition-idioms`

VideoDetails is mainly used while decoding y4m, but it is carried
around in the configuration, initializing various internal structures.

Having all encoding-related fields in a single structure simplifies
setting up and configuring the encoder, as well as offering
an easier-to-use and possibly a more extensible API.

Fix #910.

Format some very long lines of code

Monty Montgomery authored 6 years ago and Thomas Daede committed 6 years ago

This also implements initial infrastructure for tracking RUs of any legal size
relative to superblocks

* Move use statements to the heads of their modules
* Split local and external module use statements
* Reorder use statements alphabetically by module name

Raphaël Zumer authored 6 years ago and Thomas Daede committed 6 years ago

Fixes an unused macro warning.

Support all chroma sampling formats.

Mostly exclusive to 10 bit and 8 bit input. Roughly a 10% speedup when last measured.

Josh Holmer authored 6 years ago and Thomas Daede committed 6 years ago

This opens the path to finer control by the user over the encoding
options, and centralizes the speed preset logic in one location.

Closes #290