Yushin Cho authored 6 years ago and Thomas Daede committed 6 years ago

I.e. multiple of 4x4 blocks in AV1.

Kyle Siefring authored 6 years ago and Thomas Daede committed 6 years ago

* Implement idct 4x4 in rust.

* Add uncommited changes [squashme]

* Make some changes based on code review.

* More changes.

* For code review

Frank Bossen authored 6 years ago and Yushin Cho committed 6 years ago

* Search more intra modes in inter frames

Reuse exisiting intra mode lists to determine which intra modes
to search in an inter frame

* Remove duplicate line

Frank Bossen authored 6 years ago and Yushin Cho committed 6 years ago

There is no need for additional variable specific to chroma
since the plane_offset() function already does the proper
correction

Frank Bossen authored 6 years ago and Yushin Cho committed 6 years ago

Chroma distortion was sometimes being computed on inexistant 2x2
blocks

Andrew D'Addesio authored 6 years ago and Thomas Daede committed 6 years ago

On MinGW, the "no_build_target(cfg!(windows))" line unfortunately
prevents out/lib/pkgconfig/aom.pc from being created, causing the
"// MSVC" code branch to be taken which results in a linker error
(-laom not found).

Rather than fixing pkg-config, we can pass an absolute path to
libaom.a like we already do to aom.lib for MSVC. This has the
benefit that rav1e can be compiled with MinGW directly from cmd,
where pkg-config usually isn't available.

Tested on:
* MinGW-Builds 8.1.0 (cmd, msys2 terminal)
* Visual Studio 2017 15.8.1 (cmd, msys2 terminal)

Frank Bossen authored 6 years ago and Thomas Daede committed 6 years ago

Use right shift opertator for faster code

Frank Bossen authored 6 years ago and Thomas Daede committed 6 years ago

Make most calls use the non-mutable version

* Refactor RDO loop to avoid code duplication

Use same code regardless of whether a loop over chroma modes
is needed

* Test skip on and off in RDO loop

* Don't search transform type when skipping

* Don't try to skip when using intra modes

* Fix issues with speed 0 and speed 1

Handling of < 8x8 was incorrect in CDEF and in reset_skip_context()

* Use dense sampling for chroma components in above_coeff_context and left_coeff_context

Frank Bossen authored 6 years ago and Thomas Daede committed 6 years ago

* WIP motion vector reference search

* More searches

* Have a version that compiles

* Actually call MV prediction function

Fix a few bugs along the way

* Add computation of context for inter mode

* Have find_mvrefs return a mode_context value and use it

* Test but never select intra mode in inter frame

* Fixes to context derivation for inter mode

Some success with mixing intra and inter in a same frame but
still buggy

* Fixes to find MV references functions

Can encode/decode 20 frames at speed 4, but not at slower speed
settings

* Fix MV scan

Now intra/inter mixing works for all speed settings

* Fix issues that arose from rebase

* Remove lines that should not have been added

* Remove superfluous empty lines

* Supress compiler warnings

* A few cosmetic improvements

Yushin Cho authored 6 years ago and Yushin Cho committed 6 years ago

AWCY Result for subset1 at --speed=1

master_s1@2018-08-14T20:42:35.057Z -> fix_topdown_rdo_mode_update_s1@2018-08-15T20:06:31.213Z

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.1532 | -0.2611 |     N/A |  -0.1801 | -0.1267 | -0.1137 |    -0.2634

Raphaël Zumer authored 6 years ago and Thomas Daede committed 6 years ago

Fix test script section name

Raphaël Zumer authored 6 years ago and Thomas Daede committed 6 years ago

* Add basic AppVeyor configuration

* Update appveyor.yml

Remove benchmark run

Make the library code not depend to the y4m crate.

Raphaël Zumer authored 6 years ago and Thomas Daede committed 6 years ago

* Handle profiles and chroma sampling in sequence header

* Move y4m::Colorspace to ChromaSampling mapping to rav1e.rs

Raphaël Zumer authored 6 years ago and Thomas Daede committed 6 years ago

* Attempt to process 10-bit Y4M input

Currently compiles, encodes and decodes with desynchronization

* Use high bit depth quantization tables

* Move context::clamp() to util.rs

* Fix partition context initialization for high bit depth

* Enable and test 10-bit input

* Add 10- and 12-bit test clips to build.sh

Commented out by default, to enable as needed for local testing.

* Use the same bit depth as y4m_dec for y4m_enc

* Fix benchmark module compilation

* Fix high bit depth test encoding in 8-bit

* Fix header syntax for 12-bit 4:2:0 input

* Enable and test 12-bit input

* Reflect 12-bit support in README.md

* Keep the default C420jpeg color space in y4m_encoder

* Do not allow reconstruction output at high bit depths

* Fix reconstruction output at high bit depths

* Clean up reconstruction copy to frame buffers

Add a check for reconstructed vs decoded image difference on each build in build.sh

Clang is needed in order to run integration tests. Fixes #122.

Block boundary calculation is correct by accident-- make it correct on purpose.

Split analysis and filtering of CDEF superblocks so that RDO can do a
single find_dir before a number of filter tests at diffreretn
strengths.

Rebase without eliminating high-bitdepth stubs in functions.

Superblocks are 16 blocks wide, not 8.  Use the MAX_MIB_SIZE constant.

Implement basic cdef RDO, using cdef_dist for luma and sse for chroma

Implement SuperBlock centered CDEF computation
convert cdef_filter_frame to use SuperBlock-level computation
Add rdo_cdef_decision placeholder

Yushin Cho authored 6 years ago and Monty Montgomery committed 6 years ago

This reverts commit 8c545350.

We can't guarantee we meet a level, so choose level 31 for now
which has no constraints.