Ran autoupdate and edited setup until all warnings disappeared.

This will avoid running valgrind on bash and instead validate the
test programs themselves.

Implemented --disable-oggz to ignore oggz when present.

Closes #14

See merge request !6

This disable to configure check for oggz and avoid building examples using liboggz.
Added CI test to verify the option work.

Fixes #14

Make sure to check the correct flac init return values.

See merge request !5

Check for valid return values when calling
FLAC__stream_encoder_init_stream() and FLAC__stream_decoder_init_stream().

Handle non-OK return values as an error, instead of looking for
return values that can not be returned from these methods.  Note, the
integer value for both FLAC__STREAM_DECODER_SEARCH_FOR_METADATA,
FLAC__STREAM_ENCODER_OK, FLAC__STREAM_DECODER_INIT_STATUS_OK and
FLAC__STREAM_ENCODER_INIT_STATUS_OK are all zero, so the behaviour of the
code do not change.

This change avoid the following compiler message:

  flac.c: In function ‘fs_flac_decode_header’:
  flac.c:269:10: warning: comparison between ‘FLAC__StreamDecoderInitStatus’ and ‘enum <anonymous>’ [-Wenum-compare]
    269 |        ) != FLAC__STREAM_DECODER_SEARCH_FOR_METADATA)
        |          ^~
  flac.c: In function ‘fs_flac_enc_headers’:
  flac.c:610:10: warning: comparison between ‘FLAC__StreamEncoderInitStatus’ and ‘enum <anonymous>’ [-Wenum-compare]
    610 |        ) != FLAC__STREAM_ENCODER_OK)
        |          ^~

Use correct oggz argument type in examples.

Closes #13

See merge request !4

Changed expected function signature of fs_vector_foreach to expect void.

See merge request !3

This bring the method in ine with the return type of fs_comment_free().

This avoid the following compiler message:

  comments.c: In function 'fish_sound_comments_free':
  comments.c:426:40: error: cast between incompatible function types from 'void (*)(FishSoundComment *)' {aka 'void (*)(struct _FishSoundComment *)'} to 'int (*)(void *)' [-Werror=cast-function-type]
    426 |   fs_vector_foreach (fsound->comments, (FishSoundFunc)fs_comment_free);
        |                                        ^

The examples using oggz must use oggz_package as the
second argument to read_package for the callback to be acceptable by
oggz_set_read_callback().  Adjust the method signature to use
oggz_package and extract the required ogg_package members from this
one to avoid compiler message like this:

fishsound-identify.c: In function ‘main’:
fishsound-identify.c:101:37: warning: passing argument 3 of ‘oggz_set_read_callback’ from incompatible pointer type [-Wincompatible-pointer-types]
  101 |   oggz_set_read_callback (oggz, -1, read_packet, NULL);
      |                                     ^~~~~~~~~~~
      |                                     |
      |                                     int (*)(OGGZ *, ogg_packet *, long int,  void *) {aka int (*)(void *, ogg_packet *, long int,  void *)}
In file included from /usr/include/oggz/oggz.h:576,
                 from fishsound-identify.c:39:
/usr/include/oggz/oggz_read.h:109:44: note: expected ‘OggzReadPacket’ {aka ‘int (*)(void *, oggz_packet *, long int,  void *)’} but argument is of type ‘int (*)(OGGZ *, ogg_packet *, long int,  void *)’ {aka ‘int (*)(void *, ogg_packet *, long int,  void *)’}
  109 |                             OggzReadPacket read_packet, void * user_data);
      |                             ~~~~~~~~~~~~~~~^~~~~~~~~~~

Fixes #13

Patch configure.ac to specify config macro dir.

See merge request !2

Changed identifiers "__FISH_SOUND_H__" and "_FishSoundFlacInfo" to avoid C++ naming convention conflict.

<URL: https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier >
states:

  "Each name that contains a double underscore __ or begins with an underscore
  followed by an uppercase letter is reserved to the implementation for any use."

Changed __FISH_SOUND_H__ to FISH_SOUND_H_INCLUDED and dropped unused
_FishSoundFlacInfo to avoid conflicting with this convention.

Fixes #12.

Make sure to call PKG_PROG_PKG_CONFIG explicitly after looking for
pkg-config, instead of implicitly in the first call to
PKG_CHECK_MODULES, which is only called when --disable-vorbis is not
used.  This ensure pkg-config work when vorbis is disabled.

Moved the fs_speex_free_buffers() method outside the #if FS_DECODE block,
as it is needed to release structures independent of --disable-decode.

The FishSoundFlacInfo pcm_out array only exist when decode is not
disabled.  No use trying to update it outside a #if FS_DECODE block.

Start using AC_CONFIG_MACRO_DIR to specify where to place the macros.

Inspired by patch from Dimitri John Ledkov <xnox@ubuntu.com> and Ubuntu, using
a simpler approach.

Starting from libflac 1.1.3 the flac API uses "size_t" as parameter type for
the number of bytes in all callback functions.

Patch by Martin Steghöfer via Debian and <URL: https://bugs.debian.org/766394 >.

This line is only needed if packages that build against libfishsound
needs access to the Cflags of the required packages. In this case, the
listed packages (vorbis, speex, flac) are precisely the packages that
libfishsound provide a wrapper API for, so apps compiling against
libfishsound really should not need their headers directly.

This was not a problem in 0.9.1, but in 1.0.0 the FLAC headers are
exported, and this include a really regrettably misnamed assert.h, which
shadows the system assert.h and causes compilation of sonic-visualiser
to fail.

I've tried removing the Requires: line and can report that it results in
a functioning sonic-visualiser build.

Reported-by: hircus

* Please add feature suggestions here!

* Please remove the entry from TODO in the same commit that implements
a feature listed there :-)

Avoids debug crash with libFLAC 1.2.1; tested on Windows (x64)

Reported-by: Денис Кулаков <kulakov_denis@mail.ru>

Patch by Chris Double

Handle the case where the comment has no value but has an = sign.

Tested with the files in that bug report:
http://upload.wikimedia.org/wikipedia/commons/e/ee/SongFromCottonField.ogg
http://whatthebert.com/ihameed/boomtss/zurie-piratesxaimusremix.ogg

This commit changes the policy of fs_comment_validate_byname() to
allow NULL-value comments, and changes fs_comment_new() to handle
the case where value=NULL.

This commit should pass "make check", including the policy change
introduced in the previous commit.

This test changes the policy on what comments are valid, to allow
plain comments, not of the form KEY=VALUE (the condition reported
in Mozilla #520500).

As this commit only modifies the test suite, 'make check' is
expected to fail.

This reverts the following commits:

"Mozilla 520500: test for (len > 0)"
46faa6b4

Revert "Mozilla 520500, Mozilla 521863"
ac2015db

Due to a regression introduced by ac2015db, which fails to pass
"make check", and chops the first character off all comment values.

This change was present in the patch for 520500 but not 521863.
Applied separately after discussion with Chris Pearce.

Don't reject files with vorbis comments with name or
values of length 0.

Patch by Chris Pearce