OggzReadPacket() is of the type int (*)(void *, oggz_packet *, long int, void *)
Functions read_packet() have signature int (*)(void *, ogg_packet *, long int, void *)
Despite embedding ogg_packet, oggz_packet is of a different type, and modern C refuses to silently cast between them.
And all op->whatever should be replaced with op->op.whatever in said read_packet() functions.
See also: https://bugs.gentoo.org/929253
See patch at https://github.com/gentoo/gentoo/pull/40025/files for a fix
changed the description
mentioned in commit 5ac845e7
Heh, I wish I had discovered this before I wrote the fix in !4 (merged). I notice my approach is quite different from the one in gentoo. Can you please have a look at mine to see if I did not misunderstand something? It seem like a simpler approach to the changes in https://github.com/gentoo/gentoo/pull/40025/files, but I do not really know the code much and might have made a mistake.
My solution haven't been merged yet, but I feel that renaming argument in function signature from op to opz is correct and I will adopt it soon.
Your change looks also correct and, as far as understand C semantics and compiler optimizations, should produce exactly same code.
I need to look at it again and decide what actually decreases complexity of the functions.
Thank you for the quick response. Note, I plan to push to get a new release of libfishsound out as soon as possible. If Gentoo got more patches to consider, please send them our way, preferably as a merge request on gitlab.xiph.org.
After 15 years, I believe it is time to bring Linux distro editions of libfishsound in sync again. :)
mentioned in commit e1ee9862
https://github.com/gentoo/gentoo/tree/master/media-libs/libfishsound/files We have two more patches here, but I don't know how appropriate they are for upstream at the moment.
libfishsound-1.0.0-c99.patch is already handled by 4a9d94ae, and I do not understand libfishsound-1.0.0-pc.patch . Is it a bug in the FLAC .pc file that is being compensated for in libfishsound? Feel free to make a pull request to have a place to discuss ut.
closed
mentioned in commit 181f9956