* With cmake 4 [1] the support for cmake 3.5 or lower was cut [2]
* cmake 4 was deployed on github.com around 2025-04-02
  which started to break many things e.g. ogg
* cmake 3.5 was released in 2016 [3] and many versions in the
  3.30 range has warned about the deprecation

[1] https://cmake.org/download/#latest
[2] https://cmake.org/cmake/help/v4.0/release/4.0.html
[3] https://www.kitware.com/cmake-3-5-0-available-for-download/

Inspired by proposal in https://github.com/xiph/ogg/pull/91/.

This report an error message when malloc() fail instead of just crashing
with invalid memory accesses.

Test for prefix /usr drop adding -L/usr/lib to linker arguments and
-I/usr/include as compiler argument if it is set.

Patch from SuSe and their m4.patch.

This got rid of these messages from autoconf when using XIPH_PATH_OGG
from ogg.m4:

  configure.ac:5: warning: The macro `AC_HELP_STRING' is obsolete.
  configure.ac:5: You should run autoupdate.
  ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
  ../../ogg.m4:8: XIPH_PATH_OGG is expanded from...
  configure.ac:5: the top level
  configure.ac:5: warning: The macro `AC_TRY_RUN' is obsolete.
  configure.ac:5: You should run autoupdate.
  ./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
  ../../ogg.m4:8: XIPH_PATH_OGG is expanded from...
  configure.ac:5: the top level
  configure.ac:5: warning: The macro `AC_TRY_LINK' is obsolete.
  configure.ac:5: You should run autoupdate.
  ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from...
  ../../ogg.m4:8: XIPH_PATH_OGG is expanded from...
  configure.ac:5: the top level

evpobr authored 3 years ago and Petter Reinholdtsen committed 3 weeks ago

Closes https://github.com/xiph/ogg/issues/76.

The --enable-gcc-sanitizers configure option build with a few of
the GCC sanitizers enabled and use it when running tests.

The --enable-valgrind-testing option build and run the tests
using valgrind.

Adjusted gitlab CI to test both option.

Rewrote check target to use autoconf test framework and report test
status.

Updated from docker image gcc:9 to gcc:14 to use more recent
compiler and software.

Introduced template rule .autotools used by all autotools based builds.

Only install cmake for autotools builds doing distcheck.

This expose signed/unsigned and different size type issues.

Remove the obsolete `AC_HEADER_STDC` macro. Recent autoconf versions
complain that this isn't worth checking for as all current platforms
provide the standard C90 headers.

Addresses a lint running `./autogen.sh`.

This used to work, but has been failing on more recent macos images
with an error about aclocal not finding the libtool macros:

    error: Libtool library used but 'LIBTOOL' is undefined
    src/Makefile.am:5:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
    src/Makefile.am:5:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.

Install it from homebrew like we do automake and pkg-config.

Also fix other instances of similar patterns.

Thanks to kunitoki for the report.

Fixes #2305

Without this include, CTest can still be run. Removing this cleans up MSVC
solution explorer, as CTestDashboardTargets (Continuous, Experimental,
Nightly and NightlyMemoryCheck) no longer show up

Make it a little more clear how steps correspond, and add 'build'
to both workflow names so the intention of the runs is explicit
on the actions page.

This only runs on linux and macOS, but supports the important
`distcheck` target.

We ask homebrew to install libtool and pkg-config on macOS.
These are required for the autotools build, but aclocal
at least seems not to be available in the latest image.

We don't do a general homebrew update since that can take several
minutes, at least doubling the time it takes to runthhe job.
Just using the defaults the image provides is a better tradeoff.

Run cmake build and test steps on the three supported desktop
targets. Default compiler and so on is fine.

Although we define an environment variable to hold the path
to the cmake build directory, we must use the noisier expression
syntax of the github job builder to substitute into each
command line for portability across both unix and windows
shell syntax.

The windows image also requires an explicit build config
switch, `-C Debug` or similar, for ctest to execute even
though CMakeLists.txt doesn't define alternate build
configurations. On linux and macos ctest runs fine without
the extra argument.

These should match http://downloads.xiph.org/releases/ogg/SHA256SUMS

Result of running `make -C doc/libogg update-doc-version`.

Summarize recent changes, and bump the package version and soname.
There have been no interface changes, just bug fixes.

Daniel Engberg authored 3 years ago and Ralph Giles committed 3 years ago

"Install CMake package configiguration module" --> configuration

Signed-off-by: Daniel Engberg <daniel.engberg.lists@pyret.net>
Signed-off-by: Ralph Giles <giles@thaumas.net>

Makes diffs a little more clean.

Ozkan Sezer authored 4 years ago and Ralph Giles committed 4 years ago

The idea was to trigger maximum optimizations, but to date
compilers only go up to -O3, so this in ambiguous.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Properly export Ogg target when added via `add_subdirectory()`.

newsize is a long, but storage is an int. This means the allocation
could succeed but storage would overflow.

Closes #2300

The link pointed to the wrong structure documentation.
Looks like a cut-and-paste error.

thp-hatch authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Gitlab now supports a `default` section on the build description,
which sets defaults which can be overridden by specific jobs.

This encapsulates things a little better and avoid duplicating
runner tags.

Specify an explicit version of the base container image for more
repeatable results. Note that this will need to be bumped periodically.

We've moved hosting to a gitlab instance. Make use of the built-in
integration testing framework to verify commits.

This has parallel jobs to run the autotools and cmake builds.

Note that the autotools job needs cmake because the `distcheck`
target verifies that the generated source package also builds
correctly with cmake, in particular to check that the necessary
files are included.

This description of the build is old and unmaintained. It's not
useful to have untested code in the tree.

Signed-off-by: Thomas Daede <daede003@umn.edu>

This description of the build is very old, unmaintained, and
not integration tested. I don't think it's useful to users,
who can use the supported autotools or cmake builds, or just
add the few source files directly to their own projects.

Signed-off-by: Thomas Daede <daede003@umn.edu>

willson-chen authored 5 years ago and Tristan Matthews committed 4 years ago

Close the C4244 warning while compiling under windows with cmake+msbuild.

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

This effectively reverts f8ce071e which was
probably broken by 6449883c.

willson-chen authored 5 years ago and Ralph Giles committed 5 years ago

add `make test` to README.md

On windows platform, building with MinGW can run 'make check' (autoconf)
and 'ctest' or 'make test' (cmake), while building with MSBuild can only
run 'ctest -c Release|Debug'.

Signed-off-by: Ralph Giles <giles@thaumas.net>