Jesús de Vicente Peña authored 4 years ago and Felicia Lim committed 4 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Reported by toto.

This way CI pipeline runs for branches and tags
and makes it show up in merge requests where
a branch is used as source branch.

Makes all jobs show up in merge request CI
indicator (not just the whitespace job) and
only runs a single CI pipeline, without the
additional detached pipeline.

https://docs.gitlab.com/ce/ci/yaml/#workflowrules-templates



Signed-off-by: Ralph Giles <giles@thaumas.net>

Tim Gates authored 4 years ago and Ralph Giles committed 4 years ago

There is a small typo in celt/fixed_generic.h.

Should read `nearest` rather than `neareast`.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Xavier Claessens authored 4 years ago and Ralph Giles committed 4 years ago

meson.source_root() and meson.build_root() have been deprecated in
latest Meson release because they are a trap. They point to the root of
parent project instead of root of current subproject. Meson 0.56.0 added
meson.project_source/build_root() but it is just as easy to use
meson.current_source/build_dir() in the root meson.build file and avoids
bumping required meson version.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Davide Beatrici authored 4 years ago and Ralph Giles committed 4 years ago

This is required for Windows because it doesn't have RPATH,
thus it fails to find Opus if it's not in the same directory
as the executables or in PATH.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Davide Beatrici authored 4 years ago and Ralph Giles committed 4 years ago

This is required in case the output path for tests is changed
by a project adding Opus as submodule.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Tested on:
 - Linux/x86* with gcc
 - Android armv7 arm64 x86 x86_64 with clang
 - Windows x86 x86_64 with Visual Studio 2017
 - Windows x86 x86_64 with MinGW
 - macOS x86_64 with clang
 - iOS arm64 x86_64 with clang

Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>

https://gitlab.xiph.org/xiph/opus/-/merge_requests/13

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Specify the precision as float to avoid truncating from double.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Actually check for read errors instead of just storing the
return value in a variable that then never gets checked.

Also fixes "conversion from 'size_t' to 'int', possible loss
of data" compiler warnings on Windows with MSVC caused by
storing the size_t returned by fread() into an int variable.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

_WIN32 is defined on all Windows platforms by every compiler that
targets Windows. We do not need WIN32 at all.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Resolves https://github.com/xiph/opus/pull/104

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

This broke 5 years ago in 43120f00

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Use a versioned gcc container image for more consistent
test results. This is the same version we're using for
other projects, but of course it will need to be bumped
periodically.

The current gcc release is 10.2. The oldest supported
release is 8.4, so this is in the middle of the support
window.

Signed-off-by: Marvin Scholz <epirat07@gmail.com>

sezero authored 5 years ago and Jean-Marc Valin committed 4 years ago

.. just like the way it is done in celt/x86/x86cpu.c.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Use the fuzzed sub-length of the input data instead of the whole input.

The autotools build doesn't set OPUS_HAVE_RTCD for arm targets,
assuming all the supported intrinsics will work on the runtime
cpu.

The cmake build however defines this by default when the neon
extension is available on the target. On Linux, the runtime
cpu detection reads /proc/cpuinfo, so removing stdio.h from
celt/os_support.h meant that the cmake build for arm targets
failed.

We don't currently have ci runs for that configuration, so
this only became apparent through manual testing.

Signed-off-by: Marcus Asteborg <maastebo@microsoft.com>
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

willson-chen authored 5 years ago and Ralph Giles committed 4 years ago

Add newer source directories to the destdir file tree so we
can include all sources referenced from opus_sources.mk.

Signed-off-by: Ralph Giles <giles@thaumas.net>

willson-chen authored 4 years ago and Ralph Giles committed 4 years ago

[[ ]], the compound command is not supported by all
shell interpreter. [ ], the buildin command is more
common.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Davide Beatrici authored 4 years ago and Mark Harris committed 4 years ago

CMAKE_SOURCE_DIR corresponds to the top project's source directory.
CMAKE_BINARY_DIR corresponds to the top project's binary directory.

The usage of these variables doesn't cause any problems when Opus is built as a standalone project.

This is not the case when Opus is added as submodule: the variables are set by the project that calls "add_subdirectory()".

The fix consists in using PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR, which always refer to the current project.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>