Thanks to Barry for proposing specific text for the changes.

Ralph Giles correctly points out that the sequence number field in
 Ogg pages starts couting at 0, so counting from 1 in the diagram
 might be confusing.

For RFC 6716, the RFC Editor converted our Wikipedia URLs into
 stable ones that would always point at the same version of the
 page.
We're close enough to the end that we can go ahead and do that in
 advance (and also update the dates to reflect the most recent
 version).

- Clarify that 125,829,120 is just 120 MB.
- Add a figure to Section 3 of an example logical stream.
- Add a reference for Q notation.
- Refer to the downmixing figures in the text.
- Clarify that user comments are UTF-8.
- Clarify that the -573 and 111 gain values are examples.
- Add specific advice to implementors on areas that have security
   implications.

Apparently the IETF does not like having the BSD copyright in the
 .xml source (despite the CODEC WG's IPR advisor saying this was
 okay), so we need a new version.

It looks like this was included accidentally.

Thanks to mark4o for pointing out I'd missed this in the previous
removal.

Felicia Lim authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

It looks like this was included accidentally.

The improves the reproducibilit of the build. The date
was nice to have, but there's a version string at the
top which should identify the release correctly.

The copyright date could actually be incorrect, since
it is based on the build date and not the last-changed
date.

Use https urls.
Indent nesting levels and add missing </td>.

Hopefully this is even clearer.
Thanks again to Mark Harris for the suggestion.

This avoids the claim that all possible Opus implementations would
 run at rates that divide 48 kHz.
Thanks to Mark Harris for raising the issue.

This also removes the request for an additional grant from the IETF
 Trust on the final RFC.
I believe this is sufficient to exercise our ability to allow
 downstream modifications as proposed in RFC 5377 Section 4.4.
See the discussion at
 <https://www.ietf.org/mail-archive/web/codec/current/msg03169.html>
 for details.

Thanks to Ron Lee for the suggestion.

Thanks to Sabrina Tanamal for pointing out the ambiguity.

The set of supported Doxygenfile keys changes from release
to release, often resulting in warnings about needing to
upgrade the configuration file. However, this isn't
practical given the various versions different developers
have installed.

However, for the vast majority of keys we just want the
default values, so instead only include the keys we've
specifically set and let doxygen fall back to defaults
for all the rest.

Thanks to Joel Halpern for the suggestion.

Thanks to Joel Halpern for pointing out the discrepancy.

Thanks to Ben Campbell for the report.

From AD review.

From AD review.

Ralph Giles authored 9 years ago and Ralph Giles committed 9 years ago

This is a reasonable choice for the (non-linear) dynamic
range of mu-law. A-law is technically 13 bit, maybe 12;
experimentation is needed.

Per irc discussion with Jean-Marc, Ron, and Mark Harris.

Also alphabetize the rest of the file.

Avoids accidental name collisions

ISO C90 forbids mixed declarations and code, r=bustage

Add a reset function for the TonalityAnalysisState struct
and call it on encoder reset.

Move the state struct above the clear line in OpusEncoder
so reset doesn't clobber reusable fields. Currently this
is only the arch field, which is moved to to top of the
struct so we can use the same memset-to-the-end pattern
as OpusEncoder.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

This interns the asm flags parameter in the state struct
so we don't need to pass it with every call. It can be
expensive, so we don't want to query every run_analysis()
call, but since this (private) api is used by webrtc code
we need to provide a supportable interface for filling in
the correct value.

Note the initialization code is partially duplicated between
opus_encoder_init and the OPUS_RESET_STATE switch case, so we
must re-initialize it there.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>