Thanks to Mark Harris for the report.

Reported in https://trac.xiph.org/ticket/2241

Should no longer cause discontinuities in the noise after 5 packets

Previously silence would cause the divide approximation on 0/0 to return a
very large value, which would be interpreted as a transient

Also remove most <preamble>/<postamble> usage for expository text,
 as most places center the result, which looks ugly (only local
 xml2rfc HTML output does not center: tools.ietf.org HTML output
 still does, as does the .txt version).

To avoid confusion with an RFC 6716 encoder/decoder.
No part of this document is intended to update RFC 6716.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

I *think* all we need to do is document this and the RFC editors
will take care of it.

We mention this in the description of Channel Mapping Family 0.
Might as well link to RFC 7587.

Review comment from Mo Zanaty.

This improves readability in the xml2rfc html output, but
generates Markdown-style *bold* in the txt output, and
more importantly in the nroff-like html output of the
tools.ietf.org toolchain, which Mo Zanaty and some in
IRC objected to.

Based on Mo Zanaty's review comments.

Response to comments from Mo Zanaty. Using "muxer/demuxer"
really isn't less ambiguous than "encoder/decoder" but does
help distinguish between this draft and a 'codec encoder/decoder'
described by the Opus RFC.

Radu Velea authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Radu Velea authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Jonathan Lennox authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics.

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

These were causing "syntax error near unexpected token `fi'" in the
 generated configure on some systems, because they produced an

  else

  fi

 with no commands between the two.

Rhishikesh Agashe authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Timothy B. Terriberry authored 9 years ago and Jean-Marc Valin committed 9 years ago

Some of the fields present in NE10's float state struct are not
 present in the fixed-point version, but we were generating
 initializers for them anyway.
Also, the float modes were not up-to-date with the output of
 dump_modes.

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Extends usage of NEON optimized fixed-point FFT optimizations
in libNE10 to clt_mdct_forward and clt_mdct_backward.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Uses NEON optimized fixed point FFT routines in NE10 library.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Viswanath Puttagunta <viswanath.puttagunta@linaro.org>
Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Optimize opus decode (float only) use case using ARM NE10.
Mainly effects opus_ifft and ctl_mdct_backward and related
functions.

Work based on previous Encode optimization using ARM NE10
library. See previous commit for details on how to enable
this.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Optimize opus encode (float only) usecase using ARM NE10
library. Mainly effects opus_fft and ctl_mdct_forward
and related functions.

This optimization can be used for ARM CPUs that have NEON
VFP unit. This patch only enables optimizations for ARMv7.

Official ARM NE10 library page available at
http://projectne10.github.io/Ne10/



To enable this optimization, use
--enable-intrinsics --with-NE10=<install_prefix>
or
--enable-intrinsics --with-NE10-libraries=<NE10_lib_dir> --with-NE10-includes=<NE10_includes_dir>

Compile time checks made during configure process to make sure
optimization option available only when compiler supports NEON
instrinsics.

Runtime checks made to make sure optimized functions only called
on appropriate hardware.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Timothy B. Terriberry authored 9 years ago and Jean-Marc Valin committed 9 years ago

This library is linked statically with libopus.so, so nothing
 changes on an installed system.
This merely simplifies linking in the unit tests.
Based in part on a patch originally by Viswanath Puttagunta
 <viswanath.puttagunta@linaro.org>.

Timothy B. Terriberry authored 9 years ago and Jean-Marc Valin committed 9 years ago

This is needed for the SMALL_DIV_TABLE constants added in commit
 ec5d01cb.

Rhishikesh Agashe authored 9 years ago and Jean-Marc Valin committed 9 years ago

Brings MIPS in sync with the ARM/SSE optimizations that added "arch" parameters.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>