Tom Denton authored 3 years ago and Jean-Marc Valin committed 3 years ago

Prevent int32 overflow when applying HARM FIR filter in NSQ.c by using a saturating sum. This matches behavior in NSQ_del_dec.c.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Tom Denton authored 3 years ago and Jean-Marc Valin committed 3 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

These could result in 16-byte-aligned loads on unaligned data, causing
a segfault.

Before, an overflow can occur in the last loop if `len` is not a
multiple of 4 as OP_CVTEPI16_EPI32_M64 tries to load 64 bits, but there
are insufficient bits allocated in `x`.

encoder

Tim-Philipp Müller authored 3 years ago and Ralph Giles committed 3 years ago

For git worktree directories .git is not a directory
but a file that points to the real .git dir.

The `update_version` script used by other builds
works correctly with git worktrees.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 3 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

This was introduced in February, and fails the corresponding
check in gitlab ci runs.

Also indent the subsequent lines to match and correct typos.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The LPCs are computed in 32-bit, so increase the allowed range from +/-8
to +/-64 to avoid overflows caught during fuzzing. Before downshifting
back down to the +/-8 range in the final 16-bit output, perform bandwidth
extension to avoid any additional overflow issues.

Jesús de Vicente Peña authored 4 years ago and Felicia Lim committed 4 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Reported by toto.

This way CI pipeline runs for branches and tags
and makes it show up in merge requests where
a branch is used as source branch.

Makes all jobs show up in merge request CI
indicator (not just the whitespace job) and
only runs a single CI pipeline, without the
additional detached pipeline.

https://docs.gitlab.com/ce/ci/yaml/#workflowrules-templates



Signed-off-by: Ralph Giles <giles@thaumas.net>

Tim Gates authored 4 years ago and Ralph Giles committed 4 years ago

There is a small typo in celt/fixed_generic.h.

Should read `nearest` rather than `neareast`.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Xavier Claessens authored 4 years ago and Ralph Giles committed 4 years ago

meson.source_root() and meson.build_root() have been deprecated in
latest Meson release because they are a trap. They point to the root of
parent project instead of root of current subproject. Meson 0.56.0 added
meson.project_source/build_root() but it is just as easy to use
meson.current_source/build_dir() in the root meson.build file and avoids
bumping required meson version.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Davide Beatrici authored 4 years ago and Ralph Giles committed 4 years ago

This is required for Windows because it doesn't have RPATH,
thus it fails to find Opus if it's not in the same directory
as the executables or in PATH.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Davide Beatrici authored 4 years ago and Ralph Giles committed 4 years ago

This is required in case the output path for tests is changed
by a project adding Opus as submodule.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Marcus Asteborg authored 4 years ago and Ralph Giles committed 4 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Tested on:
 - Linux/x86* with gcc
 - Android armv7 arm64 x86 x86_64 with clang
 - Windows x86 x86_64 with Visual Studio 2017
 - Windows x86 x86_64 with MinGW
 - macOS x86_64 with clang
 - iOS arm64 x86_64 with clang

Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>

https://gitlab.xiph.org/xiph/opus/-/merge_requests/13

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Specify the precision as float to avoid truncating from double.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Actually check for read errors instead of just storing the
return value in a variable that then never gets checked.

Also fixes "conversion from 'size_t' to 'int', possible loss
of data" compiler warnings on Windows with MSVC caused by
storing the size_t returned by fread() into an int variable.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

_WIN32 is defined on all Windows platforms by every compiler that
targets Windows. We do not need WIN32 at all.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Resolves https://github.com/xiph/opus/pull/104

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

This broke 5 years ago in 43120f00

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Use a versioned gcc container image for more consistent
test results. This is the same version we're using for
other projects, but of course it will need to be bumped
periodically.

The current gcc release is 10.2. The oldest supported
release is 8.4, so this is in the middle of the support
window.

Signed-off-by: Marvin Scholz <epirat07@gmail.com>

sezero authored 5 years ago and Jean-Marc Valin committed 4 years ago

.. just like the way it is done in celt/x86/x86cpu.c.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Use the fuzzed sub-length of the input data instead of the whole input.