Thanks to Robert Clausecker <fuz@FreeBSD.org> for the patch.

The MSVC implementations already was, but the others were not.
This is an implementation detail that should not have external
 visibility.
The public interface is opus_select_arch().

MSVC doesn't have a real __m128i_u, so it would generate an aligned
store, resulting in a segfault. Adding explicit loadu/stureu
intrinsics to make sure the compiler generates unaligned load/store

Tristan Matthews authored Mar 07, 2024 and Jean-Marc Valin committed Mar 07, 2024

These were not being included in the tarball in spite of being referenced.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Martin Storsjö authored Mar 05, 2024 and Jean-Marc Valin committed Mar 05, 2024

clang exposes this intrinsic even in 32-bit mode, if targeting >= armv8,
whereas gcc does not, see:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95399


Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Only manage to warn on non-pointers

Many new features, API still compatible

silk_burg_analysis() could return a slightly negative value on zero
input, which would cause a negative, which the log didn't like.

Without the fix, ubsan would complain about some of the
NULL pointer checks from test_opus_api.

Added proper saturation and rounding

Michael Klingbeil authored Feb 29, 2024 and Jean-Marc Valin committed Mar 01, 2024

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Matches the C code and avoids undefined behaviour

Rudi Heitbaum authored Aug 21, 2023 and Jean-Marc Valin committed Feb 29, 2024

cc.get_define returns str (not bool)

Fixes:
Fetching value of define "__APPLE__" :
../meson.build:316:12: ERROR: Object <[StringHolder] holds [str]: ''> of type str does not support the `bool()` operator.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

It was breaking badly for PLC.

-fargan-synthesis not -fargan_synthesis

Used to be disabled for LM==0 because of the unreliable energy in
one-bin bands. Now we just used the max with the previous energy to
stabilize things.

Michael Klingbeil authored Feb 23, 2024 and Jean-Marc Valin committed Feb 23, 2024

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Timothy B. Terriberry authored Feb 22, 2024 and Jean-Marc Valin committed Feb 23, 2024

The existing code in vec_avx.h produced
  warning: dereferencing type-punned pointer will break
   strict-aliasing rules
 with gcc 6.4.0.
We already had a macro to work around this within the rules of the
 C standard, but trying to use that here does not get optimized
 into a single MOVD like we were hoping.
Replacing it with memcpy() instead does get optimized correctly,
 but requires switching from a macro to an inline function in order
 to be able to declare a local variable and return a value.
We already have such an inline function in NSQ_del_dec_avx2.c, so
 hoist that out and use it everywhere, and then convert vec_avx.h
 to use it also.

Also, remove -march=native because of AVX512VNNI and valgrind

Fixes regression in 83368e6.
vcgez_s16() is A64-only, but vcge_s16(..., vdup_n_s16(0)) works
everywhere.

broken in 9cf12e92