Promote the new tag definitions to a separate subsection,
balance tags, improve wording, and document our motivation
for the R128 tags.

Thanks to Calvin Walton for pointing this out.

Patch from Greg Maxwell in response to implementor feedback.
https://www.ietf.org/mail-archive/web/codec/current/msg03053.html

Conflicts:
	doc/draft-ietf-payload-rtp-opus.xml

Timothy B. Terriberry authored 10 years ago and Jean-Marc Valin committed 10 years ago

Here are my proposals to resolve a few issues with the current
 draft.
See the corresponding message to the list for details.

Timothy B. Terriberry authored 10 years ago and Jean-Marc Valin committed 10 years ago

This is the result of an editing pass for clarity and consistency.

genversion.bat would fail if an argument was passed with quotations.
This is because the quotations were not being stripped before using
them as variables, causing the _temp files not being created.

Adding ~ to the arguments causes windows to strip the quotations,
enabling it to be used with path names containing spaces and the
MSVS pre-build event.

Signed-off-by: Ralph Giles <giles@mozilla.com>

Marcello Caramma (mcaramma) authored 10 years ago and Jean-Marc Valin committed 10 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Addresses comments from several months ago

OPUS_AUTO should now work fine, while using OPUS_BITRATE_MAX would still
be a bad idea for controlling CBR rate for multistream. The encoder should
now throw an error early on if max_data_bytes is just too small to do anything.

Koen Vos authored 10 years ago and Jean-Marc Valin committed 10 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Koen Vos authored 10 years ago and Jean-Marc Valin committed 10 years ago

- Bug fix: the CNG synthesis filter output consisted of only the prediction
  values, now added the input to that.
- CNG excitation level now takes into account the level from the PLC (since
  both PLC and CNG can be active at the same time).
- CNG is now called before PLC_glue() to smoothen the transition out of CNG.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Rhishikesh Agashe authored 10 years ago and Jean-Marc Valin committed 10 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

When an overflow happened in silk_sum_sqr_shift(), the sample pair causing
the overflow would be counted twice. This would lead to the C0 in
silk_burg_modified() being too large and cause problems on loud, tonal
signals. Thanks to Marcello Caramma for tracking down the problem.

Use abs(sweep_bps) instead of fabs(). "sweep_bps" is an integer,
and on some compilers this line generates a warning.

Patch from Tina le Grand.
Reviewed by Jean-Marc Valin

The patch in 76e831d9 got us most of the way there, but
 out-of-tree builds required a second Makefile.am rule, which was
 missing @ARM2GNU_PARAMS@.
Also, the arm2gnu.pl was terminating argument processing on any
 argument beginning with --, rather than an argument that was just
 -- by itself (as is the normal convention in GNU programs).
That meant it never saw the --apple flag even when it was passed.

Thanks to Jonathan Lennox for the report and for testing.

Martin Storsjö authored 11 years ago and Timothy B. Terriberry committed 11 years ago

This allows building the arm assembly for iOS.

This checks for the __APPLE__ preprocessor built-in define to
determine whether this extra handling should be enabled.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Martin Storsjö authored 11 years ago and Timothy B. Terriberry committed 11 years ago

This avoids having to use the public symbol name when jumping here,
on platforms where the public symbols have an underscore prefix.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Bruno Randolf authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Martin Storsjö authored 11 years ago and Jean-Marc Valin committed 11 years ago

This is required in order to build using the built-in assembler
in clang.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcello Caramma (mcaramma) authored 11 years ago and Jean-Marc Valin committed 11 years ago

In that case, the yp0 and yp1 ended up aliasing for the last element,
despite being marked as restrict.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Bump version and date for draft-ietf-codec-oggopus-03 submission.

Move more text into figure pre/postamble to fix rendering issues
in the xml2rfc html output. These need to be manually re-indented
in the txt output before submission. :(

Fix resampling frequency choice algorithm, which was missing a word.

Fix some spelling and make some minor enphasis changes.

maks authored 11 years ago and Jean-Marc Valin committed 11 years ago

The code was wrong, but did not have any impact on user-visible behaviour
because all it did was change an internal-only error code.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Broken by 306d7f5a