Not sure if it was the original intent, but we now reduce the
loss percentage threshold for pitch scaling as 1/nFramesPerPacket
since only the first frame will have pitch scaling anyway.
As a side effect, this brings back the original behavior of
disabling pitch scaling for 0% loss.

Reduces fluctuations in the non-FEC target bitrate.

Making LTP scaling depend on the bitrate and whether FEC is on.
The thresholds for scaling 1 and 2 are now independent.

Reviewed by Mark Harris

Reviewed by Mark Harris

Reviewed by Mark Harris

MULT16_32_QX() is now implemented using a signed-unsigned multiply,
so the second argument can now have one extra bit compared to the
old signed-signed implementation.

Reviewed by Mark Harris

We need to move the history out of the way before we write to the
shape array X, or else we get corruption of the audio.

Signed-off-by: Jean-Marc Valin <jmvalin@amazon.com>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

When building with FLOAT_APPROX.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

To avoid issues with empty compilation units.

Also #error if RTCD is enabled without a detection method, like Arm.
A number of SILK functions also still used the lookup tables, even
 when RTCD was disabled.
Fix those, too.

The indentation for nested #ifs was all over the place.

Marcus Asteborg authored 2 years ago and Jean-Marc Valin committed 2 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

Opus compare is used to generate test vectors so no cosmetic changes
is taken. Hence we move this warning to level 4 for opus compare.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

This commit addresses the issues of not finding lrintf and lrint. We
switch to check_symbol_exists instead per cmake documentation. Also
make sure to link math lib for detection for nix.

For MSVC the issue for non x86 builds was that the standard was set to
default which is 199409L. This resulted in not using lrintf even that
it was found. To address this we set the C standard to C11 and it will
only apply to newer versions of MSVC where the /std flag is supported.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Signed-off-by: Doug Nazar <nazard@nazar.ca>

Commit 6577534a switched from using __get_cpuid() to
 __get_cpuid_count(), but the corresponding configure check was not
 updated.
Since __get_cpuid_count() was introduced much later, make sure we
 check for the function we actually use.

Thanks to Mark Harris for the report.

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Alexander Traud authored 3 years ago and Mark Harris committed 2 years ago

Doxygen was not able to resolve the references because it looked
for OPUS_APPLICATION_VOIP/@ref.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

This will fix -Wunused-but-set-variable on gcc
9.3 release build. Also remove unused assert.h.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Reviewed by Jean-Marc Valin.

Reviewed by Timothy B. Terriberry.

The values were never used, but ubsan + valgrind would complain.

Reviewed by Mark Harris

Even when the macro itself would overflow.

Reviewed by Mark Harris

Reviewed by Mark Harris

Reviewed by Mark Harris

Reviewed by Mark Harris

Timothy B. Terriberry authored 2 years ago and Jean-Marc Valin committed 2 years ago

The underlying objects are all 8-bit integers.
Verified that the generated assembly still just uses MOVD.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Unlike OPUS_SET_INBAND_FEC(1), the encoder does not necessarily
switch to SILK if we have music.

Estimate the rounding error so that we can have a useful margin of
error when checking the asm against the C code even when the float
operations get reordered due to -ffast-math.