DRED will absorb the bitrate variation

Starting with compute_linear()

Signed-off-by: Jean-Marc Valin <jmvalin@amazon.com>

When ready, change DRED_EXTENSION_ID to the final ID, remove
DRED_EXPERIMENTAL_VERSION completely, and change DRED_EXPERIMENTAL_BYTES
to zero (eventually remove it).

Should work for both CBR and VBR. In the CBR case, we can make
CELT VBR and use DRED to fill the rest.

If configuring CELT for CBR but controlling the bitrate with
OPUS_SET_BITRATE rather than nbCompressedBytes, then the range
coder buffer would never get resized. AFAICT this could never
be triggered in Opus because CBR was also controlled by
nbCompressedBytes.

Avoids interactions with redundancy settings

SET_BITRATE is now the total bitrate again

We weren't reserving enough bytes for the DRED extension

Also, don't code DRED that's redundant with the main packet

Should make synthesis easier in the future

Adding a 'D' byte to signal the DRED experiment, along with a version
number byte. This entire commit will be reverted once DRED is finalized
and given a non-experimental extension number.

Unlike OPUS_SET_INBAND_FEC(1), the encoder does not necessarily
switch to SILK if we have music.

This was introduced in February, and fails the corresponding
check in gitlab ci runs.

Also indent the subsequent lines to match and correct typos.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Jesús de Vicente Peña authored 4 years ago and Felicia Lim committed 4 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Reland "Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision"

This flag was modified after calling the Silk encoder function. This commit corrects that behavior by introducing those modifications before calling the Silk encoder.

Slightly modified comments by Felicia Lim

Signed-off-by: Felicia Lim <flim@google.com>

Revert "Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision"

This reverts commit ea3b30f9.