Pavel P authored 7 years ago and Ralph Giles committed 7 years ago

Signed-off-by: Ricardo Constantino <wiiaboo@gmail.com>

Linfeng Zhang authored 7 years ago and Jean-Marc Valin committed 7 years ago

This bug is introduced in commit 85fb8a1d.

Change-Id: I3822cdfc1308ca62ce03da008260de8f4b04596c

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

|frame_size_enum| in tests/test_opus_encode.cl:117 is flagged as potentially
uninitialized but get_frame_size_enum() will fail anyway if a valid value is
not found.

Migrating opus-codec.org to a static site generator inserted
a redirect into the download path, which the actual testvectors
at https://opus-codec.org/static/testvectors/opus_testvectors.tar.gz.

Add the -L option to the suggested curl invocation so the redirect
is followed to download the actual resource. Without this one
gets the html redirection fallback page.

Andrew Larkin authored 7 years ago and Felicia Lim committed 7 years ago

Signed-off-by: Felicia Lim <flim@google.com>

The new detector for SWB vs FB is unreliable due to the hack
that was required to get 24 kHz analysis working. We're now err
on the side of FB just to make sure.

Uniform layout is easier for external tools to parse,
especially maintaining one source file per line.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Allows spaces in path arguments

Both versions of silk/tables_NLSF_CB had symbols
named silk_NLSF_CB1_Wght_Q9 which causes problems
if both files are build as part of the same
compilation unit. Rename the wideband version
to include a 'WB' string to avoid the conflict.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Linfeng Zhang authored 8 years ago and Jean-Marc Valin committed 7 years ago

Call celt_inner_prod_neon() and remove redundant code.

Change-Id: I980e94330ae75c10297b9035fac221515aee144f

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Linfeng Zhang authored 8 years ago and Jean-Marc Valin committed 7 years ago

The floating-point optimizations are not bit exact with C functions,
because of the different orders of floating-point operations.
But they are bit exact with the simulation C functions which simulate
the floating operations in the optimizations.

Change-Id: I149fda5b602fd5712b16fc8983df3c6c0c9e76ad

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Linfeng Zhang authored 8 years ago and Jean-Marc Valin committed 7 years ago

This optimization is bit exact with C functions.

Change-Id: Ia9ce6dd3c20d2f56dbd43ddc02d1a6fd6554608d

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Linfeng Zhang authored 8 years ago and Jean-Marc Valin committed 7 years ago

Should call celt_inner_prod().
This requires the API change of celt_pitch_xcorr() by passing in
"arch".

We tested on x86 and arm, and got bit exact results as original.

Change-Id: I606915da6a196f327ce81f4a5ae32811f4c1fabb

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Linfeng Zhang authored 8 years ago and Jean-Marc Valin committed 7 years ago

Should call celt_inner_prod().

This change is bit exact as original, except for x86 floating-point.
In x86 floating-point, it calls celt_inner_prod_sse() which may have
different output with the change of floating-point operations' orders.

Change-Id: Ia2381e2e198a84296ac28305183f15be842b3454

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

This was sometimes causing the music probability to be stuck at
zero at the beginning of files

Jonathan Lennox authored 7 years ago and Timothy B. Terriberry committed 7 years ago

It's unnecessary, and isn't defined correctly on floating-point.

This makes us correctly use Neon functions (in floating-point mode) on
platforms where Neon is detected by RTCD.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

We boost bands that either cause leakage or are filled with leakage

Now scaling the energy to the same value is would be in floating-point

It seems like letting CBR use up to 2/3 of the bit is still a win