Clang is needed in order to run integration tests. Fixes #122.

Block boundary calculation is correct by accident-- make it correct on purpose.

Split analysis and filtering of CDEF superblocks so that RDO can do a
single find_dir before a number of filter tests at diffreretn
strengths.

Rebase without eliminating high-bitdepth stubs in functions.

Superblocks are 16 blocks wide, not 8.  Use the MAX_MIB_SIZE constant.

Implement basic cdef RDO, using cdef_dist for luma and sse for chroma

Implement SuperBlock centered CDEF computation
convert cdef_filter_frame to use SuperBlock-level computation
Add rdo_cdef_decision placeholder

Yushin Cho authored Aug 10, 2018 and Monty Montgomery committed Aug 10, 2018

This reverts commit 8c545350.

We can't guarantee we meet a level, so choose level 31 for now
which has no constraints.

Raphaël Zumer authored Aug 09, 2018 and Thomas Daede committed Aug 09, 2018

* Attempt to process 10-bit Y4M input

Currently compiles, encodes and decodes with desynchronization

* Use high bit depth quantization tables

* Move context::clamp() to util.rs

* Fix partition context initialization for high bit depth

* Enable and test 10-bit input

* Add 10- and 12-bit test clips to build.sh

Commented out by default, to enable as needed for local testing.

* Use the same bit depth as y4m_dec for y4m_enc

* Fix benchmark module compilation

* Fix high bit depth test encoding in 8-bit

* Fix header syntax for 12-bit 4:2:0 input

* Enable and test 12-bit input

* Reflect 12-bit support in README.md

Monty Montgomery authored Aug 08, 2018 and Thomas Daede committed Aug 08, 2018

* Improve block bounds checking in CDEF

The block bounds calculation in CDEF was doing nothing due to a
calculation error; due to misunderstanding why, a second, moredetailed
guard was added later that should have been unneccessary.

Correct the earlier/easier check to function properly, remove the more
complex and now unneccessary later guard.

* Move CDEF strength calculaiton outside block loop

Basic CDEF strength is signaled and calculated by superblock; no need
to repeat for each block

Monty Montgomery authored Aug 07, 2018 and Thomas Daede committed Aug 07, 2018

Implement split partition encode with 'everything up to the CDEF
strength' and 'everything after the CDEF strength' coded in parallel
separate Writers, such that the CDEF strength can be determined at the
end of frame encode.

Does not yet perform the CDEF RDO.

Monty Montgomery authored Aug 07, 2018 and Thomas Daede committed Aug 07, 2018

I needed to same more information than I thought for the WriterRecorder---
local range state was not being used properly during replay.

Yushin Cho authored Aug 07, 2018 and Thomas Daede committed Aug 07, 2018

If tune=Psychovisual is used, min partition size is enforced to 8x8.

* Add WriterCounter to EC

Only counts bits, stores nothing.  This is for throwaway cost analysis
decisions.

* Convert RDO to using throwaway WriterCounter

Instead of checkpoint/rollback on a master Writer, use throwaway
WriterCounter instances in RDO cost computaiton

* Add a bitstream writer record/replay abstraction

Allows encoding piecemeal, out of order, or in parallel; a recording
writer can be played back into a master bitstream range encoder.

* Reimplement od_ec_enc and Writer, add record/playback

Flatten od_ec_enc and Writer, as one was a thin wrapper for the other
Reimplement range encoding writer as a Writer trait and encoding backend
Reimplement recording as a second backend to same Writer trait

Yushin Cho authored Aug 03, 2018 and Yushin Cho committed Aug 03, 2018

It has been wrong when SB is partitioned.

Yushin Cho authored Aug 03, 2018 and Yushin Cho committed Aug 03, 2018

Inter mode prediction can be done for a whole partition,
instead of each tx-block.

TODO: Fix the plane_offset() function of BlockOffset struct for chroma
planes, so that bo.plane_offset() can be directly and conveniently
called instead of using a block of long codes in several places.

* Document pkg-config dependency

* Document dependencies on Windows

* Support build on Windows

Frank Bossen authored Aug 03, 2018 and Thomas Daede committed Aug 03, 2018

Use smaller rounding offset in inter blocks to produce more
zero coefficients

Luca Barbato authored Aug 03, 2018 and Thomas Daede committed Aug 02, 2018

Cargo would try to compile each file at the root of benches/ as
stand alone benchmark.

Disable the behaviour.

* Create proper structure for reference frame buffer

Also move reference frame buffer into frame invariants to
avoid having to pass an additional parameter to each function
requiring access to reference frame buffer.

* Add basic inter prediction function

Basic inter prediction function copies collocated samples
from first frame in reference frame set.

* Add mapping from reference frame index to slot in buffer

Add array that maps a reference frame index such as LAST_FRAME
into a slot of the reference frame buffer

* Use GLOBALMV instead of ZEROMV

For consistency with text specification

* Add support for writing reference frames in inter mode

* Add write_inter_mode() for NEWMV and GLOBALMV inter pred modes

Also,
- Rename ZEROMV prediction mode to GLOBALMV
- RDO search include GLOBALMV mode if inter frame
- Import CDFs required to encode NEWMV or GLOBALMV modes
- Add write_tx_tree() for tx block coding for a inter mode. This
function is also for var-tx, but currently only one tx block for a inter
mode partition since tx_mode in frame header is set as LARGEST_TX atm.

* Fix ref_frame storage and counting

* Add basic inter prediction function

Basic inter prediction function copies collocated samples
from first frame in reference frame set.

* Add mapping from reference frame index to slot in buffer

Add array that maps a reference frame index such as LAST_FRAME
into a slot of the reference frame buffer

* Use GLOBALMV instead of ZEROMV

For consistency with text specification

* Fix entropy coding issues for inter modes

* Fix issue with transform type and small blocks

Thomas Daede authored Aug 02, 2018 and Yushin Cho committed Aug 02, 2018

This reverts commit a78777c6.

Frank Bossen authored Aug 02, 2018 and Thomas Daede committed Aug 02, 2018

* Create proper structure for reference frame buffer

Also move reference frame buffer into frame invariants to
avoid having to pass an additional parameter to each function
requiring access to reference frame buffer.

* Add basic inter prediction function

Basic inter prediction function copies collocated samples
from first frame in reference frame set.

* Add mapping from reference frame index to slot in buffer

Add array that maps a reference frame index such as LAST_FRAME
into a slot of the reference frame buffer

* Use GLOBALMV instead of ZEROMV

For consistency with text specification

* Add support for writing reference frames in inter mode

* Add write_inter_mode() for NEWMV and GLOBALMV inter pred modes

Also,
- Rename ZEROMV prediction mode to GLOBALMV
- RDO search include GLOBALMV mode if inter frame
- Import CDFs required to encode NEWMV or GLOBALMV modes
- Add write_tx_tree() for tx block coding for a inter mode. This
function is also for var-tx, but currently only one tx block for a inter
mode partition since tx_mode in frame header is set as LARGEST_TX atm.

* Fix ref_frame storage and counting

* Add basic inter prediction function

Basic inter prediction function copies collocated samples
from first frame in reference frame set.

* Add mapping from reference frame index to slot in buffer

Add array that maps a reference frame index such as LAST_FRAME
into a slot of the reference frame buffer

* Use GLOBALMV instead of ZEROMV

For consistency with text specification

* Fix entropy coding issues for inter modes

Yushin Cho authored Aug 01, 2018 and Yushin Cho committed Aug 01, 2018

The assert checks whether an input pixel value in cdef_find_dir()
is within a valid range, for ex, 0 <= (pixel_value >> bitdepth) <= 255.