Skip to content
Snippets Groups Projects
  1. Jul 27, 2016
    • Timothy B. Terriberry's avatar
      Sanity improvements to oc_dec_headerin() error returns. · 50fd339b
      Timothy B. Terriberry authored
      In the case where we got a data packet before receiving all three
       headers, the old code would check to see if the second through
       seventh bytes matched the magic string "theora" (extremely
       unlikely, but possible), and if so, return TH_EBADHEADER, otherwise
       return TH_ENOTFORMAT.
      That this was not consistent was a bit non-sensical.
      
      5a5f5bb2 changed to returning TH_EBADHEADER if we got a data
       packet after receiving the first header, but left the old behavior
       for the first packet.
      Change instead to explicitly return TH_ENOTFORMAT if the first
       header was missing (since we only check one bit of the packet to
       determine whether or not it's a data packet, odds are it's a packet
       for some other kind of data, like a Vorbis header).
      We continue to return TH_EBADHEADER if we see a data packet after
       encountering a valid header, but before reading all three.
      
      Also re-arrange the NULL checks to follow continue to allow the
       undocumented ability to pass in NULL for parameters which are not
       needed by the next header in the sequence.
      E.g., it's perfectly all right to pass NULL for _setup when
       expecting to read the comment header next.
      In this case we'll now return TH_EBADHEADER instead of TH_EFAULT if
       the packet was actually a data packet.
      50fd339b
    • Timothy B. Terriberry's avatar
      NULL check _tc and _setup even for data packets. · 5a5f5bb2
      Timothy B. Terriberry authored
      Our documentation says we will, so we should.
      
      Thanks to Chris Peterson for the report.
      
      Fixes #2279.
      5a5f5bb2
  2. May 25, 2016
  3. Aug 27, 2015
    • Ralph Giles's avatar
      Use the float latex package in the spec. · fbb27580
      Ralph Giles authored
      Newer texlive distributions require \usepackage{float} for
      the [H] figure layout directive. We use this to make sure
      the header layout figures are at the top of their respective
      sections for conventional reference like in an RFC, so requiring
      the additional package is safer than falling back to standard
      latex [h] or [!h].
      
      Note that [H] from the float package is incompatible with
      fallback specifiers.
      
      The configure script will automatically check for the new package.
      fbb27580
  4. Oct 31, 2014
    • Timothy B. Terriberry's avatar
      Fix mismatched oc_mb_fill_cmapping11 signature. · 12f20c7a
      Timothy B. Terriberry authored
      oc_mb_fill_cmapping11() was defined without the last two parameters
       of its fellow mapping functions, meaning it got called with extra
       undeclared parameters.
      
      This could confuse the emscripten JavaScript cross-compiler's asm.js
       optimizations, as it's very picky about function signatures.
      
      Fixes #2068.
      Patch by Brion Vibber <brion@pobox.com>.
      
      svn path=/trunk/theora/; revision=19261
      12f20c7a
  5. Jul 23, 2014
  6. Jun 10, 2014
  7. Apr 04, 2014
  8. Feb 17, 2014
  9. Feb 11, 2014
  10. Nov 18, 2013
  11. Feb 23, 2013
  12. Jan 08, 2013
  13. Jun 02, 2012
  14. May 08, 2012
    • Timothy B. Terriberry's avatar
      Fix pp_sharp_mod calculation. · 0ae66d56
      Timothy B. Terriberry authored
      This was broken when the dequant_tables indexing changed in commit
       r16102, but it only affected post-processing quality, so we never
       noticed.
      With gcc 4.8.0, this can now trigger a segfault during decoder
       initialization.
      
      svn path=/trunk/theora/; revision=18268
      0ae66d56
  15. Mar 31, 2012
  16. Mar 06, 2012
  17. Mar 02, 2012
    • Timothy B. Terriberry's avatar
      Remove some redundant NULL checks and fix a free on error return. · de386d3e
      Timothy B. Terriberry authored
      ref_frame_data was being allocated with the aligned allocator, but
       freed with the normal _ogg_free() function on failure, which
       doesn't work.
      This would only cause a problem if there was just enough memory to
       satisfy the reference frame allocation (just over 4.5 or 9 bytes
       per pixel) but not enough for the fragment buffer offets (1/16 or
       1/8th byte per pixel).
      
      svn path=/trunk/theora/; revision=18219
      de386d3e
    • Timothy B. Terriberry's avatar
      Make telemetry work with striped decoding. · 813791c8
      Timothy B. Terriberry authored
      This allows it to be used from dump_video without having to disable
       striped decoding there.
      
      svn path=/trunk/theora/; revision=18218
      813791c8
  18. Feb 11, 2012
    • Ralph Giles's avatar
      Fix a duplicate word. · 22c475eb
      Ralph Giles authored
      Thanks to darkstarbyte for pointing out the typo.
      
      svn path=/trunk/theora/; revision=18195
      22c475eb
  19. Jul 13, 2011
    • Timothy B. Terriberry's avatar
      Clean up some ARM asm issues. · f6d84864
      Timothy B. Terriberry authored
      1) Allow specification of the section alignment and make the
          default alignment 4 bytes (like the RVCT manual says it should
          be).
         This ensures that linking our ARM asm into a Thumb executable
          won't get the section placed on a 2-byte boundary.
      2) Add a linker hint to indicate we don't need an executable stack.
         Otherwise it assumes we do.
      3) Stop building and linking to an (empty) armopts object file.
         This is needed to make 2) work, since we include this file, so
          we can't add the linker hint at the end of it, and linking in
          just one object without that hint makes the whole library ask
          for an executable stack.
      
      svn path=/trunk/theora/; revision=18031
      f6d84864
  20. May 31, 2011
  21. May 29, 2011
  22. May 20, 2011
  23. May 19, 2011
  24. May 04, 2011
    • Timothy B. Terriberry's avatar
      Another overflow fix. · b758596b
      Timothy B. Terriberry authored
      This extends the fix from r17276 dealing with the removal of the DC
       skip-prevention flag in r17174.
      If we allow SKIPing even when the cost is right near the maximum
       representable SSD, then the cost of other blocks can push it over
       the edge, causing us to randomly skip a block halfway through the
       macroblock.
      
      svn path=/trunk/theora/; revision=17959
      b758596b
  25. May 03, 2011
    • Ralph Giles's avatar
      Remove the --disable-float configure option, and the corresponding · 3c04b48d
      Ralph Giles authored
      THEORA_DISABLE_FLOAT C preprocessor symbol.
      
      This originally disabled slow floating point code in the library,
      but the critical path code has all been removed. It also used
      to disable function of th_granule_time() which returns a double,
      but it has not done so since prior to the 1.0 release, and there
      have been no complaints.
      
      It might be helpful to restore this option if it eliminated    
      the th_granule_time() API entry entirely, so that platforms
      without native floating point don't have to link to an emulation
      library, but in the absence of a request we prefer shorter code.
      
      svn path=/trunk/theora/; revision=17951
      3c04b48d
    • Timothy B. Terriberry's avatar
      Update documentation for TH_ENCCTL_SET_BITRATE. · b86b5376
      Timothy B. Terriberry authored
      Make a note that passing 0 for the bitrate may not be guaranteed to
       return an error in future versions.
      
      svn path=/trunk/theora/; revision=17949
      b86b5376
Loading