Philip Jägenstedt authored 12 years ago and Gregory Maxwell committed 12 years ago

I stumbled upon the typo in README.draft, so took the opportunity to
grep for common misspellings using List_of_common_misspellings.txt for
hunspell.

This could be confusing/misleading.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This patch also includes some small edits/additions to the main API
 documentation.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This patch also includes some small edits for the main API
 documentation.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This avoids allocating any buffers on the stack that depend on the
 total channel count.
Such buffers could easily exceed the size of the
 NONTHREADSAFE_PSEUDOSTACK.
It also checks the frame_size argument in both the encoder and
 decoder to avoid allocating large stack buffers for opus_encode()
 calls that would fail anyway or opus_decode() calls that would
 never use all that space anyway.

In particular we no longer document the default complexity because
we're not guaranteeing to keep the default value constant.  In the
future the default may be lowered in order to keep the default
speed constant.

In addition to general reformatting and cleanup, this fixes a
 couple of important mistakes:
- The arguments to OPUS_SET_FORCE_CHANNELS are now 1 and 2, not 0
   and 1 (as they were when this was called OPUS_SET_FORCE_MONO).
- The default encoder mode is now constrained VBR, not unconstrained
   VBR.
It also documents defaults for all the other parameters.

Jean-Marc Valin authored 12 years ago and Gregory Maxwell committed 12 years ago

This implements an API used in future encoders to avoid dynalloc doing silly things
on periodic LSB patterns and to reduce the bitrate on near-silence.

The usage of restrict in include/opus_custom.h was missed
by the prior commit replacing this keyword with a macro.

Also fixes some prototype/function agreement with respect to
restrict.

The usage of restrict in include/opus_custom.h was missed
by the prior commit replacing this keyword with a macro.

We had previously advised people to -Drestrict on
non-C99 compilers, but this creates problems for
some of the MSVC headers. Instead this just
uses a macro and defines it sanely.

This is used to avoid dynalloc doing silly things on periodic LSB
patterns and to reduce the bitrate on near-silence.

This is the less-surprising behavior and will hopefully
result in fewer corner case bugs (e.g. losing gain
after seeking). This commit also updates the documentation.

This CTL was requested by Nicolas George for FFmpeg.

Gregory Maxwell authored 12 years ago and Jean-Marc Valin committed 12 years ago

In places where an ignored return or a null-arg is a sure indication
of a bug add the GCC warning attributes. The null arg annotation
is not enable for Opus itself because it will cause the compiler
to optimize out some null checks. I don't trust our callers
quite that much.

This was a problem for static builds

Unlike the other headers, opus_multistream.h didn't declare
itself to be C code, causing confusing errors when the caller
tries to use the functions from C++.

This reverts commit 9f407afa.

Also added 3rd clause to "master" COPYING file

See http://www.ietf.org/mail-archive/web/codec/current/msg02833.html
Still more changes to come

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

The parameter descriptions look like they were copied
from encoder_create. Update them for the decode side
and repeat the clarifications about what sample rates
are allowed and what they mean.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

Also fixes a minor typo.