- May 21, 2013
-
-
Timothy B. Terriberry authored
-
Timothy B. Terriberry authored
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0068b/CIHBJEHG.html says that "Rd cannot be the same as Rm." http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0068b/CIHBJEHG.html says that "RdLo, RdHi, and Rm must all be different registers." This means that some of the early clobbers I removed really should have been there (to prevent aliasing Rd, RdLo, or RdHi with Rm). It also means that we should reverse some of the operands in the FFT's complex multiplies. This should only affect the ARMv4 optimizations. Thanks to Nils Wallménius for the report. While we're here, audit the commutative pair flags again, since I screwed up at least one of them, and eliminate some dead code.
-
- May 20, 2013
-
-
Timothy B. Terriberry authored
-
Ron authored
-
Ron authored
Needed by commit 972a34ec. Use autoreconf in autogen.sh instead of the handwritten version, it's simpler, and also updates things that we weren't handling. Drop the hand-written INSTALL file. Its information content was ~zero, and autotools wants to overwrite it with its own version, so don't fight that, just .gitignore it.
-
Timothy B. Terriberry authored
In most cases these will use __builtin_clz(). In a follow-up, we should audit usage of silk_CLZ32() and convert the places where its argument must be non-zero to use EC_ILOG() directly to avoid the test for zero (which is necessary on x86).
-
Timothy B. Terriberry authored
Since the last patch originally had them mangled (presumably by mailer, http server, or something else), let's just get rid of them.
-
Timothy B. Terriberry authored
Original patch by Aurélien Zanelli <aurelien.zanelli@parrot.com>: http://lists.xiph.org/pipermail/opus/2013-May/002078.html Revised version: - Add autconf detection (ported from libtheora). - Rename ARM5E to ARMv5E (an ARM5 is not the same thing as ARMv5!). - Use actual macros so they can still be selectively overridden. - Split out ARMv4 parts and add a few more ARMv4 macros. - Label blocks to make them easy to find in generated assembly. - Fix MULT16_32_Q15() so we can pass make check. The MDCT test passes in values larger than 2**30 for b. The new version should be just as fast (or faster, since it's easier to merge the shift with following instructions), and there's no appreciable impact on accuracy (FFT/MDCT SNR actually goes up in most cases). - Fix register constraints. We were using early-clobber flags in a bunch of places that didn't need them, and commutative-pair flags in a bunch of places that weren't actually commutative. This was Jean-Marc's fault (the original code came from Speex). - Simplify silk_CLZ16(). - Port over iFFT C_MULC asm by Andree Buschmann <AndreeBuschmann@t-online.de> from Rockbox. - Speed up the C_MULC asm by using LDRD, allowing more flexible addressing, re-ordering instructions to avoid some stalls, allowing more flexible register allocation, and getting things out of the inline asm block so the compiler can schedule them better. - Add C_MUL and C_MUL4 asm for the FFT to the encoder based, on the new C_MULC. In total, this patch gives a 22.3% speed-up on test_opus_encoder on a 600 MHz Cortex A8 using gcc 4.2.1, When restricted to ARMv4 optimizations, it gives a 9.6% speed-up on the same processor/compiler. On the conformance test vectors: Average mono quality is 97.0583 % Average stereo quality is 97.775 %
-
- May 19, 2013
-
-
Jean-Marc Valin authored
-
- May 18, 2013
-
-
Jean-Marc Valin authored
-
Ron authored
We shouldn't ever have any trailing newlines that need trimming here, and the _s version wasn't added to m4sugar.m4 until autoconf 2.63b, so this will let it work with 2.13 again.
-
Jean-Marc Valin authored
A fixed shift factor was insufficient to properly estimate the decay factor, resulting in extreme attenuation of the PLC excitation.
-
Jean-Marc Valin authored
-
- May 17, 2013
-
-
Jean-Marc Valin authored
-
Jean-Marc Valin authored
Takes into account the bitrate.
-
Jean-Marc Valin authored
This should prevent errors in the bandwidth detection from affecting quality when we have enough bits to be close to transparent.
-
Jean-Marc Valin authored
This is a follow-up on ac76b150. When Schur blows up, we set the last RC to +/- 0.99 instead of eliminating it.
-
- May 14, 2013
-
-
Jean-Marc Valin authored
New code is especially easier to justify
-
- May 12, 2013
- May 10, 2013
-
-
Ron authored
-
Ron authored
There's currently at least one way that people can legitimately get a tarball that doesn't include it, via the gitweb snapshots, so create it rather than considering that an error to be manually fixed.
-
Ralph Giles authored
This replaces the OPUS_VERSION removed by ron's auto-updater.
-
Ron authored
Drop some unneeded CINCLUDES. Drop the VPATH stuff altogether. It's entirely unused here, and some of the paths in it don't even exist and apparently never have in this tree. Drop the 'default' rule, without it there, 'all' already is the default. Drop $(TARGET) from all, it already includes 'lib' which is $(TARGET). Declare phony targets PHONY.
-
Ron authored
This one meets or exceeds the following requirements: - Version is checked/updated for every build action when in the git repo. Does not require the user to re- ./configure to get the correct version. - Version is not updated automatically when using exported tarball source. Avoids accidentally getting a wrong version from some other git repo in a parent directory of the source, and allows setting the correct version for distro package exports. - Automatic updating can be manually suppressed. For developers doing lots of change/rebuild cycles they don't plan to release, when they don't want a full rebuild triggered for every commit, and again for every change made immediately after a commit. The version will still always be updated if they do a `make dist`. - Does not require any manual updating of versions in the mainline git repo for each release aside from normal tagging. The version is recorded in one file only, that is automatically generated and will never need to be committed. - Does not require gnu-make features for the autoconf builds. It does not currently: - Keep a checksum of every source file in tarball releases to mangle the version if people modify the tarball source. Responsible people can manually update the version easily though in such cases. The version.mk file is now only used by the VC project files. Once they are updated to use the package_version file too, then it can be deleted from the repository.
-
- May 09, 2013
-
-
Jean-Marc Valin authored
-
Jean-Marc Valin authored
We stop the schur recursion before any reflection coefficient goes outside of ]-1,1[ and we force reporting a residual energy of at least 1. Assertion was: Fatal (internal) error in ../silk/fixed/noise_shape_analysis_FIX.c, line 290: assertion failed: nrg >= 0 triggered by: opus_demo voip 16000 1 12500 -bandwidth WB -complexity 10 pl04f087.stp-crash out.pcm
-
- May 08, 2013
-
-
Timothy B. Terriberry authored
silk_setup_resamples() was using x_bufFIX for two purposes, and I only allocated enough space for one of them. This patch also switches to slightly more descriptive variable names than nSamples_temp and computes the resampler input/ouput sizes in a way that a little more obviously doesn't have issues with fractional samples (and replaces a divide with a variable divisor by one with a constant divisor).
-
Timothy B. Terriberry authored
This makes all remaining large stack allocations use the vararray macros. This continues the work of 6f2d9f50 to allow compiling with NONTHREADSAFE_PSEUDOSTACK to move the memory for large buffers off the stack for devices where it is very limited. It also does this for some additional large buffers used by the PLC in the decoder.
-
Timothy B. Terriberry authored
1) The memcpy's were using sizeof(opus_int32), but the type of the local buffer was opus_int16. 2) Because the size was wrong, this potentially allowed the source and destination regions of the memcpy overlap. I _believe_ that nSamplesIn is at least fs_in_khZ, which is at least 8. Since RESAMPLER_ORDER_FIR_12 is only 8, I don't think that's a problem once you fix the type size. 3) The size of the buffer used RESAMPLER_MAX_BATCH_SIZE_IN, but the data stored in it was actually _twice_ the input batch size (nSamplesIn<<1). Because this never blew up in testing, I suspect that in practice the batch sizes are reasonable enough that none of these things was ever a problem, but proving that seems non-obvious. This patch just converts the whole thing to use CELT's vararrays. This fixes the buffer size problems (since we allocate a buffer with the actual size we use) and gets these large buffers off the stack on devices using the pseudo-stack. It also fixes the memcpy problems by changing the sizeof to opus_int16. It turns out sFIR, which saved state between calls, was being used elsewhere as opus_int32, so this converts it to a union to make this sharing explicit.
-
Timothy B. Terriberry authored
-
Timothy B. Terriberry authored
You can't use /* within a comment.
-
- May 06, 2013
-
-
Release date based on directory timestamps in https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/20.0/
-
Jean-Marc Valin authored
Stereo now gets twice the "marginal allocation" compared to mono, but has a 20 kb/s offset. This should be more realistic across a wide range of bitrates.
-
Jean-Marc Valin authored
This avoids a single low-energy band from changing the masking results.
-
- May 05, 2013
-
-
Jean-Marc Valin authored
The idea is that the rate of each stream is adjusted based on its contribution to the total energy of a stereo downmix.
-
Jean-Marc Valin authored
-
Jean-Marc Valin authored
-
Jean-Marc Valin authored
Forces CELT-only mode for LFE (despite the rate) and "locks" most of the CELT analysis: - No transient or TF - Band boost on first band - Only first two bands get PVQ bits - Forced energy decay after the first two bands
-
Jean-Marc Valin authored
Conflicts: src/opus_multistream_encoder.c
-