The change also makes the analysis run for sampling rates of 16 kHz and 24 kHz
since the features are only computed on the 0-8 kHz band. The longer time
window (20 ms instead of 10 ms) makes the tonality estimator more reliable
for low-pitch harmonics.

Thanks to Zhendong Wu for spotting the issue

Ricardo Constantino authored 8 years ago and Ralph Giles committed 8 years ago

Remove version.mk and references to it in the repo.

genversion.bat will now generate the same version strings as
update_version script, i.e. without 'v' prefix and without a
fallback if git archive is used.

If run from a release tarball it'll use package_version,
like configure. If run from a git repo, it will use the same
'git describe' with '-dirty' as update_version.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Ensure that the SILK encoder's log gain is 63, not 64, when encoding
a maximum-value delta gain index of 40.  This matches the decoder
and RFC 6716 4.2.7.4, and prevents an assertion failure in the rare
case that the gain is later independently coded.

Ricardo Constantino authored 8 years ago and Ralph Giles committed 8 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

This was just enabling commented-out code, setting a fixed
default removes dead code.

Also remove the SILK_DEBUG_STORE_CLOSE_FILES flush call from
opus_demo.

This is debugging code which is no longer used, but defining
the symbols for SILK_DEBUG_STORE_CLOSE_FILES and calling it
from opus_demo causes linking problems on Microsoft Visual Studio
where we have strict controls on public symbols and want to
test the compiled DLL.

Since the code isn't in active use, it's better to remove it
to avoid clutter and address the linking issue.

Ricardo Constantino authored 8 years ago and Ralph Giles committed 8 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Ricardo Constantino authored 8 years ago and Ralph Giles committed 8 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

frame_size_select() ensures that frame_size is a valid size or -1,
!st->variable_duration is always false, and delay_compensation is
no longer needed to choose the frame size.

That experiment never actually worked

Ricardo Constantino authored 8 years ago and Ralph Giles committed 8 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

We now try not to fold below band 17 since that produces a lot of harshness.
This mostly helps around 32-40 kb/s.

Fix Hybrid redundancy assertion failure in ec_enc_shrink(), even
if SILK produces more than maxBits, by reducing or eliminating
redundancy when necessary.  Don't reserve space for redundancy that
is too small to be used for redundancy.  When there is not enough
space for redundancy, allow the regular frame to use all the bits.

With packets of 80 ms or more, a SILK bandwidth switch was missing
the second half of the redundancy, because st->silk_bw_switch was
cleared too early before any recursive calls.

As reported by agatx in https://trac.xiph.org/ticket/2291

Reported by wtchang in trac: https://trac.xiph.org/ticket/2160

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

These rely on TF rather than short windows to avoid partial collapse.

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Also clean up comments from the last patches

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

The transient detector would trigger on low-pitch vowels, but we didn't have
enough bits to properly code the high bands as a transient, resulting in
partial collapse and unstable energy.

Different distributions of doxygen have different default
values of HAVE_DOT setting, so we need to pick a specific
setting to avoid 'missing dot' warnings on some platforms.

Doxygen uses it to generate inclusion graphs for our various
header files, which is somewhat useful, but not essential.
We therefore enable dot if it's present (usually through
the parent graphviz package) but disable it if it's not
available, silencing the warning, but not giving uniform
results.