GitLab

This line is only needed if packages that build against libfishsound
needs access to the Cflags of the required packages. In this case, the
listed packages (vorbis, speex, flac) are precisely the packages that
libfishsound provide a wrapper API for, so apps compiling against
libfishsound really should not need their headers directly.

This was not a problem in 0.9.1, but in 1.0.0 the FLAC headers are
exported, and this include a really regrettably misnamed assert.h, which
shadows the system assert.h and causes compilation of sonic-visualiser
to fail.

I've tried removing the Requires: line and can report that it results in
a functioning sonic-visualiser build.

Reported-by: hircus

* Please add feature suggestions here!

* Please remove the entry from TODO in the same commit that implements
a feature listed there :-)

Avoids debug crash with libFLAC 1.2.1; tested on Windows (x64)
Reported-by: Денис Кулаков <kulakov_denis@mail.ru>

Patch by Chris Double

Handle the case where the comment has no value but has an = sign.

Tested with the files in that bug report:
http://upload.wikimedia.org/wikipedia/commons/e/ee/SongFromCottonField.ogg
http://whatthebert.com/ihameed/boomtss/zurie-piratesxaimusremix.ogg

This commit changes the policy of fs_comment_validate_byname() to
allow NULL-value comments, and changes fs_comment_new() to handle
the case where value=NULL.

This commit should pass "make check", including the policy change
introduced in the previous commit.

This test changes the policy on what comments are valid, to allow
plain comments, not of the form KEY=VALUE (the condition reported
in Mozilla #520500).

As this commit only modifies the test suite, 'make check' is
expected to fail.

This reverts the following commits:

"Mozilla 520500: test for (len > 0)"
46faa6b4

Revert "Mozilla 520500, Mozilla 521863"
ac2015db

Due to a regression introduced by ac2015db, which fails to pass
"make check", and chops the first character off all comment values.

This change was present in the patch for 520500 but not 521863.
Applied separately after discussion with Chris Pearce.

Don't reject files with vorbis comments with name or
values of length 0.

Patch by Chris Pearce

patch by Chris Pearce

When resetting the decoder, reset the packetno so that the next
packets read are treated as headers.

Fixes crash in vorbis_synthesis: reject bad header packets

Removing unreachable code because type is unsigned
Fixing signedness warnings

with corrupt headers Mozilla bug 481601.

Adapted from a patch that fixes the crash by adding a new vorbis_dsp_init()
function to libvorbis, and calling that from fs_vorbis_init():
https://bug481601.bugzilla.mozilla.org/attachment.cgi?id=366150

It was suggested in this thread on vorbis-dev that we isolate the patch
to libfishsound, rather than also adding vorbis_dsp_init() to libvorbis:
http://lists.xiph.org/pipermail/vorbis-dev/2009-March/019791.html

Hence, this revision should replace the patch currently in use in
Firefox for Mozilla bug 481601.

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3901 8158c8cd-e7e1-0310-9fa4-c5954c97daef

vorbis.c: Remove unnecessary alloca
speex.c: Check that frame_size is not so large that the buffer size
calculations would wrap. In reality, frame_size is set by libspeex
according to the mode index specified in the file header, and is
usually equal to 320. Requires uintptr_t, checked by configure.

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3900 8158c8cd-e7e1-0310-9fa4-c5954c97daef

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3899 8158c8cd-e7e1-0310-9fa4-c5954c97daef

Patch by Matthew Gregan:
This is required when libsndfile is in a non-standard location,
e.g. /opt/local/{include,libs} on OS X with MacPorts.  configure sets
SNDFILE_CFLAGS correctly (since pkg-config is in the path),
but the examples weren't using this value when building.

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3897 8158c8cd-e7e1-0310-9fa4-c5954c97daef

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3896 8158c8cd-e7e1-0310-9fa4-c5954c97daef

of directly looking up library symbols and headers.
pkg-config patch by Viktor Gal

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3891 8158c8cd-e7e1-0310-9fa4-c5954c97daef

when parsing header
For Mozilla bug 480014

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3888 8158c8cd-e7e1-0310-9fa4-c5954c97daef

Fixes potential wrapping of strlen in fs_strdup, fs_strdup_len

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3887 8158c8cd-e7e1-0310-9fa4-c5954c97daef

and fix a typo in its documentation

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3886 8158c8cd-e7e1-0310-9fa4-c5954c97daef

strlen, accum_length checks

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3884 8158c8cd-e7e1-0310-9fa4-c5954c97daef

Avoid overflow in comment lengths

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3883 8158c8cd-e7e1-0310-9fa4-c5954c97daef

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3874 8158c8cd-e7e1-0310-9fa4-c5954c97daef

libflac encode/decode status for memory allocation errors
For Mozilla bug 468293

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3854 8158c8cd-e7e1-0310-9fa4-c5954c97daef

Towards Mozilla bug 468293

git-svn-id: http://svn.annodex.net/libfishsound/trunk@3853 8158c8cd-e7e1-0310-9fa4-c5954c97daef