This avoids an overflow on extreme signals

Thanks to Mark Harris for pointing it out.

Gives another ~2% speedup

Speeds up the encoder by about 1%

Felicia Lim authored 8 years ago and Timothy B. Terriberry committed 8 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

That was likely a mistake from a misunderstanding on the SILK bit allocation

Hybrid CBR now simply forces the SILK CBR rate to the "target" value. Also,
we're getting rid of the -2 kb/s offset for CBR, which appeared to be harmful.
In the case of hybrid constrained VBR, the cap is computed in the same way
as the target.

Previously, the bandwidth detection could (e.g.) change the bandwidth
from fullband to superwideband, and the hysteresis would then cause
bandwidth to be stuck in superwideband.

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Computes a pseudo SNR as the ratio between the running peak signal
energy to instantaneous noise energy. DTX is turned on only if this is
higher than a pre-determined threshold.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

A frame is marked as valid for DTX if it contains noise or only digital
silence. As before, there is an overhang period of 200 ms and a maximum
consecutive DTX period of 400 ms.

If the new DTX cannot be used because of the complexity setting and
sampling frequency chosen, the SILK DTX will be used instead.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Should be able to make better mode/bandwidth decisions when CBR/complexity
are involved.

The new attenuation is much smaller than previously.

New MLP doesn't attempt to classify silence as speech/music

Gradual downmix now happens in the 24 kb/s to 32 kb/s range

No values outside of +/-1 detected now.

len<0 still returns OPUS_BAD_ARG

Rather than read invalid memory

We were previously returning OPUS_BAD_ARG because the failure was
only detected in opus_repacketizer_out_range_impl() rather than in
opus_repacketizer_cat(). Checking the return value from opus_repacketizer_cat()
also addresses the last outstanding Coverity defect.